Skip to content

Fix false assumptions in 'build_docker_worker_payload' #21

Open
@ahal

Description

@ahal

We call util.docker.parse_volumes in the build_docker_worker_payload function
https://github.com/taskcluster/taskgraph/blob/main/src/taskgraph/transforms/task.py#L342

This in turn makes several false assumptions, namely that the root dir is taskcluster/ci and that there exists a kind called docker-image:
https://github.com/taskcluster/taskgraph/blob/main/src/taskgraph/util/docker.py#L305

Neither of these things are necessarily true. Rather than re-parsing the docker image's kind.yml file, we should store the path to the Dockerfile as an attribute (or tag) on the docker image task. Then we should move the check from the first link to a "verification" in util/verify.py. This way we'll be able to access the path to the Dockerfile directly from the dependency.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions