pkp#10929 Temporary fix for Production Editor's file upload issues

Author: taslangraham

api/v1/submissions/PKPSubmissionController.php

@@ -664,8 +664,37 @@ public function add(Request $illuminateRequest): JsonResponse
                     : $submitAsUserGroup->permitMetadataEdit
             );
 
+        // Production Editor group has Managerial role but is not assigned to submission stage.
+        $isManager = $submitAsUserGroup->roleId === Role::ROLE_ID_MANAGER && !$request->getUser()->hasRole([Role::ROLE_ID_SITE_ADMIN], \PKP\core\PKPApplication::SITE_CONTEXT_ID);
+        $stagesAssignedToGroup = $isManager ? Repo::userGroup()->getAssignedStagesByUserGroupId($context->getId(), $submitAsUserGroup->id) : collect();
+        $isSubmittingAsProductionEditor = $isManager && !$stagesAssignedToGroup->contains(WORKFLOW_STAGE_ID_SUBMISSION);
+        // Temporary solution for https://github.com/pkp/pkp-lib/issues/10929
+        // If submitting as Production Editor, then also assign as Author to allow full access to submission stage
+        if ($isSubmittingAsProductionEditor) {
+            $authorGroup = Repo::userGroup()->getByRoleIds([Role::ROLE_ID_AUTHOR], $context->getId())->first();
+
+            // Assign author role to user if not already assigned
+            if (!$submitterUserGroups->contains('roleId', Role::ROLE_ID_AUTHOR)) {
+                Repo::userGroup()->assignUserToGroup(
+                    $user->getId(),
+                    $authorGroup->id
+                );
+            }
+
+            // Assign Production Editor to submission as an Author to allow access to submission stage operations
+            Repo::stageAssignment()
+                ->build(
+                    $submission->getId(),
+                    $authorGroup->id,
+                    $request->getUser()->getId(),
+                    $authorGroup->recommendOnly,
+                    // Authors can always edit metadata before submitting
+                    true
+                );
+        }
+
         // Create an author record from the submitter's user account
-        if ($submitAsUserGroup->roleId === Role::ROLE_ID_AUTHOR) {
+        if ($submitAsUserGroup->roleId === Role::ROLE_ID_AUTHOR || $isSubmittingAsProductionEditor) {
             $author = Repo::author()->newAuthorFromUser($request->getUser(), $submission, $context);
             $author->setData('publicationId', $publication->getId());
             $author->setUserGroupId($submitAsUserGroup->id);

classes/invitation/core/Invitation.php

@@ -18,7 +18,7 @@
 use APP\facades\Repo;
 use Carbon\Carbon;
 use Exception;
-use Identity;
+use PKP\identity\Identity;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Support\Facades\Mail;
 use PKP\config\Config;

classes/invitation/invitations/userRoleAssignment/handlers/api/UserRoleAssignmentReceiveController.php

@@ -30,8 +30,8 @@
 use PKP\security\authorization\AnonymousUserPolicy;
 use PKP\security\authorization\UserRequiredPolicy;
 use PKP\userGroup\relationships\enums\UserUserGroupMastheadStatus;
-use PKPRequest;
-use Validation;
+use PKP\core\PKPRequest;
+use PKP\security\Validation;
 
 class UserRoleAssignmentReceiveController extends ReceiveInvitationController
 {

classes/invitation/invitations/userRoleAssignment/payload/UserRoleAssignmentInvitePayload.php

@@ -14,7 +14,7 @@
 
 namespace PKP\invitation\invitations\userRoleAssignment\payload;
 
-use DAORegistry;
+use PKP\db\DAORegistry;
 use Illuminate\Validation\Rule;
 use PKP\invitation\core\enums\ValidationContext;
 use PKP\invitation\core\InvitePayload;