pkp#10929 "Exclude user groups without submission stage access from 'submit as' options"

Author: taslangraham

classes/components/forms/submission/StartSubmission.php

@@ -23,6 +23,7 @@
 use PKP\components\forms\FormComponent;
 use PKP\config\Config;
 use PKP\context\Context;
+use PKP\facades\Repo;
 use PKP\security\Role;
 use PKP\userGroup\UserGroup;
 
@@ -152,6 +153,17 @@ protected function addSubmissionChecklist(Context $context): void
      */
     protected function addUserGroups(Enumerable $userGroups): void
     {
+        $groupsWithAccessToSubmissionStage = Repo::userGroup()->getUserGroupsByStage($this->context->getId(), WORKFLOW_STAGE_ID_SUBMISSION)
+            ->pluck('user_group_id')
+            ->toArray();
+
+        // There isn't a submission stage in OPS, so $groupsWithAccessToSubmissionStage will be empty there.
+        // For other apps, filter $userGroups to be only those with access to submission stage
+        if (!empty($groupsWithAccessToSubmissionStage)) {
+            $userGroups = $userGroups->filter(function (UserGroup $userGroup) use ($groupsWithAccessToSubmissionStage) {
+                return in_array($userGroup->id, $groupsWithAccessToSubmissionStage);
+            });
+        }
         if ($userGroups->count() < 2) {
             return;
         }