rename other DatabaseCollection generic API to use some: argument label

Author: tayloraswift

Sources/UnidocDB/DatabaseCollection.swift

@@ -160,7 +160,7 @@ extension DatabaseCollection
 extension DatabaseCollection
 {
     func insert(
-        _ elements:some Collection<some BSONDocumentEncodable & Identifiable<ElementID>>,
+        some elements:some Collection<some BSONDocumentEncodable & Identifiable<ElementID>>,
         with session:Mongo.Session) async throws
     {
         if  elements.isEmpty
@@ -181,7 +181,8 @@ extension DatabaseCollection
 }
 extension DatabaseCollection
 {
-    func insert(_ element:some BSONDocumentEncodable & Identifiable<ElementID>,
+    func insert(
+        some element:some BSONDocumentEncodable & Identifiable<ElementID>,
         with session:Mongo.Session) async throws
     {
         let response:Mongo.InsertResponse = try await session.run(
@@ -196,7 +197,8 @@ extension DatabaseCollection
 
 extension DatabaseCollection
 {
-    func upsert(_ elements:some Sequence<some BSONDocumentEncodable & Identifiable<ElementID>>,
+    func upsert(
+        some elements:some Sequence<some BSONDocumentEncodable & Identifiable<ElementID>>,
         with session:Mongo.Session) async throws -> Mongo.Updates<ElementID>
     {
         let response:Mongo.UpdateResponse<ElementID> = try await session.run(
@@ -208,7 +210,8 @@ extension DatabaseCollection
     }
 
     @discardableResult
-    func upsert(_ element:some BSONDocumentEncodable & Identifiable<ElementID>,
+    func upsert(
+        some element:some BSONDocumentEncodable & Identifiable<ElementID>,
         with session:Mongo.Session) async throws -> ElementID?
     {
         let response:Mongo.UpdateResponse<ElementID> = try await session.run(
@@ -221,22 +224,6 @@ extension DatabaseCollection
     }
 }
 
-extension DatabaseCollection
-{
-    @available(*, deprecated, renamed: "update(some:with:)")
-    func update(_ elements:some Sequence<some BSONDocumentEncodable & Identifiable<ElementID>>,
-        with session:Mongo.Session) async throws -> Mongo.Updates<ElementID>
-    {
-        try await self.update(some: elements, with: session)
-    }
-    @available(*, deprecated, renamed: "update(some:with:)")
-    @discardableResult
-    func update(_ element:some BSONDocumentEncodable & Identifiable<ElementID>,
-        with session:Mongo.Session) async throws -> Bool?
-    {
-        try await self.update(some: element, with: session)
-    }
-}
 extension DatabaseCollection
 {
     func update(
@@ -254,7 +241,8 @@ extension DatabaseCollection
     /// the passed document. Returns true if the document was modified, false if the document
     /// was not modified, and nil if the document was not found.
     @discardableResult
-    func update(some element:some BSONDocumentEncodable & Identifiable<ElementID>,
+    func update(
+        some element:some BSONDocumentEncodable & Identifiable<ElementID>,
         with session:Mongo.Session) async throws -> Bool?
     {
         let response:Mongo.UpdateResponse<ElementID> = try await session.run(

Sources/UnidocDB/Packages/PackageDatabase.Editions.swift

@@ -140,7 +140,7 @@ extension PackageDatabase.Editions
         if  placement.new
         {
             //  This can fail if we race with another process.
-            try await self.insert(edition, with: session)
+            try await self.insert(some: edition, with: session)
         }
         else if let sha1:SHA1
         {

Sources/UnidocDB/Packages/PackageDatabase.Packages.swift

@@ -111,9 +111,9 @@ extension PackageDatabase.Packages
         if  placement.new
         {
             //  This can fail if we race with another process.
-            try await self.insert(record, with: session)
+            try await self.insert(some: record, with: session)
             //  Regenerate the JSON list of all packages.
-            try await meta.upsert(try await self.scan(with: session), with: session)
+            try await meta.upsert(some: try await self.scan(with: session), with: session)
         }
         else if let repo:PackageRepo, repo != placement.repo
         {

Sources/UnidocDB/Packages/PackageDatabase.swift

@@ -111,7 +111,7 @@ extension PackageDatabase
 
         let upsert:SnapshotReceipt.Upsert
 
-        switch try await self.graphs.upsert(snapshot, with: session)
+        switch try await self.graphs.upsert(some: snapshot, with: session)
         {
         case nil:   upsert = .update
         case _?:    upsert = .insert

Sources/UnidocDB/Volumes/UnidocDatabase.swift

@@ -153,19 +153,19 @@ extension UnidocDatabase
     {
         let (index, trees):(SearchIndex<VolumeIdentifier>, [Volume.TypeTree]) = volume.indexes()
 
-        try await self.vertices.insert(volume.vertices, with: session)
-        try await self.names.insert(volume.names, with: session)
-        try await self.trees.insert(trees, with: session)
-        try await self.search.insert(index, with: session)
+        try await self.vertices.insert(some: volume.vertices, with: session)
+        try await self.names.insert(some: volume.names, with: session)
+        try await self.trees.insert(some: trees, with: session)
+        try await self.search.insert(some: index, with: session)
 
         if  volume.names.latest
         {
-            try await self.siteMaps.upsert(volume.siteMap(), with: session)
-            try await self.groups.insert(volume.groups(latest: true), with: session)
+            try await self.siteMaps.upsert(some: volume.siteMap(), with: session)
+            try await self.groups.insert(some: volume.groups(latest: true), with: session)
         }
         else
         {
-            try await self.groups.insert(volume.groups, with: session)
+            try await self.groups.insert(some: volume.groups, with: session)
         }
         if  let latest:Unidoc.Zone = volume.latest
         {