Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in vendor base64 #4

Open
karlr42 opened this issue Oct 10, 2014 · 0 comments
Open

Bug in vendor base64 #4

karlr42 opened this issue Oct 10, 2014 · 0 comments

Comments

@karlr42
Copy link

karlr42 commented Oct 10, 2014

The base64 implementation has a somewhat pointless line of code to normalise line endings. This could(and did for me personally) lead to random data corruption. See this comment on StackOverflow, and the other comments on that answer.

I have committed a fix removing the offending line as part of my pull request #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karlr42