Merge pull request #29 from teams-notifier/feat/reduce-default-db-min-pool-size

feat: reduce minimum db pool size to 1

Author: babs

config.py

@@ -12,6 +12,8 @@ class DefaultConfig:
     PORT = int(os.environ.get("PORT", "3980"))
     ACTIVITY_API = os.environ.get("ACTIVITY_API", "")
     DATABASE_URL = os.environ.get("DATABASE_URL", "")
+    DATABASE_POOL_MIN_SIZE = int(os.environ.get("DATABASE_POOL_MIN_SIZE", "1"))
+    DATABASE_POOL_MAX_SIZE = int(os.environ.get("DATABASE_POOL_MAX_SIZE", "10"))
     LOG_QUERIES = os.environ.get("LOG_QUERIES", "")
     VALID_X_GITLAB_TOKEN = os.environ.get("VALID_X_GITLAB_TOKEN", "")
     _valid_tokens: list[str]

db.py

@@ -10,6 +10,7 @@
 from pydantic import BaseModel
 
 from config import config
+from config import DefaultConfig
 from gitlab_model import GLEmojiAttributes
 from gitlab_model import MergeRequestPayload
 from gitlab_model import PipelinePayload
@@ -34,20 +35,21 @@ def __init__(
 
 
 class DatabaseLifecycleHandler:
-    def __init__(self, dsn: str, debug_queries: bool):
+    def __init__(self, conf: DefaultConfig):
         self._pool: asyncpg.Pool | None = None
-        self.debug_queries = debug_queries
-        self.dsn = dsn
+        self._config = conf
 
     async def connect(self):
         log.debug("creating database connection pool")
         self._pool = await asyncpg.create_pool(
-            dsn=self.dsn,
+            dsn=self._config.DATABASE_URL,
             server_settings={
                 "application_name": "notiteams-gitlab-mr-api",
             },
             connection_class=NoResetConnection,
             init=self.init_connection,
+            min_size=self._config.DATABASE_POOL_MIN_SIZE,
+            max_size=self._config.DATABASE_POOL_MAX_SIZE,
         )
 
         # Simple check at startup, will validate database resolution and creds
@@ -58,7 +60,7 @@ async def init_connection(self, conn: asyncpg.Connection) -> None:
         log.debug("connecting to database")
         await conn.set_type_codec("jsonb", encoder=json.dumps, decoder=json.loads, schema="pg_catalog")
 
-        if self.debug_queries:
+        if self._config.log_queries:
 
             def relog(value: asyncpg.connection.LoggedQuery):
                 log.debug(
@@ -296,5 +298,5 @@ async def _generic_norm_upsert(
         return row
 
 
-database = DatabaseLifecycleHandler(config.DATABASE_URL, config.log_queries)
+database = DatabaseLifecycleHandler(config)
 dbh = DBHelper(database)