Skip to content

Commit a49c379

Browse files
committed
Fix: Bundle format and minification in build command
1 parent 9c21732 commit a49c379

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

packages/techor/src/commands/build.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,17 +85,19 @@ export default async function build() {
8585
} else {
8686
entries = normalize(entries)
8787
}
88-
let isGlobalFile: boolean
88+
let forceBundle: boolean
8989
const extendedBuild = extend(config.build, { output: rollupOutputOptions }) as BuildOutputOptions
9090
// single entry
9191
if (extendedBuild.output.file) {
9292
if (!extendedBuild.output.format) {
9393
extendedBuild.output.format = config.build.formatOfExt[extname(extendedBuild.output.file)]
9494
}
9595
const fileBasenameSplits = basename(extendedBuild.output.file).split('.')
96-
if (fileBasenameSplits.includes('min')) extendedBuild.minify = true
97-
isGlobalFile = fileBasenameSplits.includes('global')
98-
if (isGlobalFile || fileBasenameSplits.includes('iife')) extendedBuild.output.format = 'iife'
96+
if (fileBasenameSplits.includes('min')) {
97+
forceBundle = true
98+
extendedBuild.minify = true
99+
}
100+
if (fileBasenameSplits.includes('global') || fileBasenameSplits.includes('iife')) extendedBuild.output.format = 'iife'
99101
for (const [eachInput, eachBuildOptions] of buildMap) {
100102
for (const eachOutputOptions of eachBuildOptions.outputOptionsList) {
101103
if (normalize(eachOutputOptions.output.file) === normalize(extendedBuild.output.file)) {
@@ -134,7 +136,7 @@ export default async function build() {
134136
}
135137
} as RollupInputOptions, config.build.input)
136138
buildOptions.input.input = entries
137-
buildOptions.input.external = (config.build.input.external && !isGlobalFile) && getWideExternal(config.build.input.external);
139+
buildOptions.input.external = (config.build.input.external && !forceBundle) && getWideExternal(config.build.input.external);
138140
(buildOptions.input.plugins as RollupInputPluginOption[]).unshift(
139141
...[
140142
(config.build.swc || extendedBuild.minify) && swc({ ...config.build.swc, minify: extendedBuild.minify }),

packages/techor/tests/global/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ beforeAll(() => {
77
})
88

99
it('generate iife format', () => {
10-
expect(readFileSync(join(__dirname, './dist/global.js'), 'utf-8')).toContain('(function () {')
10+
expect(readFileSync(join(__dirname, './dist/global.js'), 'utf-8')).toContain('(function (isObject)')
1111
})
1212

1313
it('should bundle all deps', () => {
14-
expect(readFileSync(join(__dirname, './dist/global.js'), 'utf-8')).toContain('function isObject(value)')
14+
expect(readFileSync(join(__dirname, './dist/global.min.js'), 'utf-8')).toContain('function isObject(value)')
1515
})
1616

1717
it('should be minifined', () => {

0 commit comments

Comments
 (0)