Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional/replacement ginkgomon start/readiness check #33

Open
sunjayBhatia opened this issue Nov 28, 2018 · 0 comments
Open

Add additional/replacement ginkgomon start/readiness check #33

sunjayBhatia opened this issue Nov 28, 2018 · 0 comments

Comments

@sunjayBhatia
Copy link
Contributor

ginkgomon currently uses the StartCheck string to check the readiness of the process it is monitoring, however for some classes of processes it would be useful to have a readiness check that does not rely on log lines.

Would you be amenable to a change that introduces a StartCheckFunc or some other generalized readiness check the user can specify to determine readiness?

Some open questions/ideas about solutions that are worth discussing:

  • what is the relative priority of this new readiness check vs. the existing output check?
  • could this replace the existing StartCheck?
    • could we enable users to implement the existing functionality by giving them access to the stdout/stderr buffer from the execed command? this could also be a builtin helper function that wires up the log check for you
  • could this instead be a socket or host/port tcp check for servers if a fully generic readiness check is not desired?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant