Removed mac-book identity override (#198)

Author: mfateev

README.md

@@ -27,6 +27,8 @@ If this does not work, see instructions for running the Temporal Server at https
 
 ## Build a configuration
 
+[Find the latest release](https://search.maven.org/artifact/io.temporal/temporal-sdk) of the Temporal Java SDK at maven central.
+
 Add *temporal-sdk* as a dependency to your *pom.xml*:
 
     <dependency>
@@ -39,14 +41,25 @@ or to *build.gradle*:
 
     compile group: 'io.temporal', name: 'temporal-sdk', version: 'N.N.N'
 
-Until the official release use the version from the temporal-java-samples [build.gradle](https://github.com/temporalio/temporal-java-samples/blob/master/build.gradle)
-
 ## Documentation
 
 The documentation on how to use the Temporal Java client is [here](http://docs.temporal.io/docs/java-quick-start).
 
 Javadocs for the client API are located [here](https://www.javadoc.io/doc/io.temporal/temporal-sdk).
 
+### macOS Users
+Due to issues with default hostname resolution 
+(see [this StackOverflow question](https://stackoverflow.com/questions/33289695/inetaddress-getlocalhost-slow-to-run-30-seconds) for more details), 
+macOS Users may see gRPC `DEADLINE_EXCEEDED` errors and other slowdowns when running the SDK.
+
+To solve the problem add the following entries to your `/etc/hosts` file (where my-macbook is your hostname):
+
+```conf
+127.0.0.1   my-macbook
+::1         my-macbook
+```
+
+
 ## Contributing
 We'd love your help in making the Temporal Java SDKL great. Please review our [contribution guidelines](CONTRIBUTING.md).
 

src/main/java/io/temporal/client/WorkflowClientOptions.java

@@ -103,9 +103,8 @@ public Builder setInterceptors(WorkflowClientInterceptor... interceptors) {
      * Override human readable identity of the worker. Identity is used to identify a worker and is
      * recorded in the workflow history events. For example when a worker gets an activity task the
      * correspondent ActivityTaskStarted event contains the worker identity as a field. Default is
-     * "unknown-mac" string on Mac or whatever <code>(ManagementFactory.getRuntimeMXBean().getName()
-     * </code> returns on any other platform. The reason for treating Mac differently is a very slow
-     * local host name resolution in a default configuration.
+     * whatever <code>(ManagementFactory.getRuntimeMXBean().getName()
+     * </code> returns.
      */
     public Builder setIdentity(String identity) {
       this.identity = identity;
@@ -139,20 +138,7 @@ public WorkflowClientOptions build() {
     }
 
     public WorkflowClientOptions validateAndBuildWithDefaults() {
-      String name;
-      if (identity == null) {
-        String osName = System.getProperty("os.name");
-        // On mac by default getLocalHost (which getRuntimeMXBean().getName() calls) takes long
-        // time. So we don't set identity on mac by default to avoid the bad user experience.
-        // https://stackoverflow.com/questions/33289695/inetaddress-getlocalhost-slow-to-run-30-seconds
-        if (osName.toLowerCase().contains("mac")) {
-          name = "unknown-mac";
-        } else {
-          name = ManagementFactory.getRuntimeMXBean().getName();
-        }
-      } else {
-        name = identity;
-      }
+      String name = identity == null ? ManagementFactory.getRuntimeMXBean().getName() : identity;
       return new WorkflowClientOptions(
           namespace == null ? DEFAULT_NAMESPACE : namespace,
           dataConverter == null ? DataConverter.getDefaultInstance() : dataConverter,