-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fix Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017… #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… and 2019 broken link Fixed Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019 broken link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I do not have full context of reviewing the PR. Passing it to other reviewers.
site/en/install/pip.md
Outdated
@@ -144,7 +144,7 @@ Note: GPU support is available for Ubuntu and Windows with CUDA®-enabled cards. | |||
* pip version 19.0 or higher for Linux (requires `manylinux2014` support) and | |||
Windows. pip version 20.3 or higher for macOS. | |||
* Windows Native Requires | |||
[Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019](https://support.microsoft.com/help/2977003/the-latest-supported-visual-c-downloads) | |||
[Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019](https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing the ?view=msvc-170
. Not sure what it means but seems to be autogenerated based on how the user is browsing the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @Venkat6871 please see @haifeng-jin 's comment above thank you
Marking this pull request as stale since it has been open for 14 days with no activity. This PR will be closed if no further activity occurs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me now. Unless others have comments, we can merge it.
… and 2019 broken link
Fixed Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019 broken link.