Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor minion files into single minion file #308

Open
nixjdm opened this issue Mar 15, 2018 · 1 comment
Open

Refactor minion files into single minion file #308

nixjdm opened this issue Mar 15, 2018 · 1 comment

Comments

@nixjdm
Copy link
Member

nixjdm commented Mar 15, 2018

Currently there is a different minion file for each provider https://github.com/terminal-labs/sample-states/tree/master/saltstack/minions. The only difference is the few grains that are set. We're currently setting the default user to vagrant for ec2, do, and virtualbox. Once we do the same for docker and lxc (which currently use the default name root I think), we don't need multiple minion files. Thus should start using a single minion file instead of minion.[provider] files. This will need a small change to our vagrantfiles.

Prereq: #306, #307

@nixjdm
Copy link
Member Author

nixjdm commented Mar 16, 2018

Implementation detail: Check for and use a minion file if it exists, if not, then fall back to minion.[provider]. This will provide backwards compatibility with the corresponding change from the sample states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant