From 50b0a86e0de8ac2699e8545d1671c9fc6eda7650 Mon Sep 17 00:00:00 2001 From: Sam Bilbow Date: Thu, 27 Nov 2025 16:10:40 +0000 Subject: [PATCH 1/5] docs: add example commands for creating a seed project in GLOSSARY.md --- docs/GLOSSARY.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/docs/GLOSSARY.md b/docs/GLOSSARY.md index 70c597e1..3c8b4295 100644 --- a/docs/GLOSSARY.md +++ b/docs/GLOSSARY.md @@ -8,6 +8,20 @@ specific meaning within the domain of knowledge. An existing GCP project with resources, services, and service accounts needed to create projects with the project factory. +For a minimal working example of a seed project, create a project using the following command in the [Cloud Console](https://console.cloud.google.com/) or the [gcloud CLI](https://cloud.google.com/sdk/gcloud): +```bash +export FOLDER_ID="" +export BILLING_ACCOUNT_ID="" +export SEED_PROJECT_ID="" + +gcloud projects create "$SEED_PROJECT_ID" \ + --name="$SEED_PROJECT_ID" \ + --folder="$FOLDER_ID" + +gcloud billing projects link "$SEED_PROJECT_ID" \ + --billing-account="$BILLING_ACCOUNT_ID" +``` + ## Seed Service Account A service account in the **Seed Project** used to create **Target Projects**. From 173c22f1597001fc9088f370822ac155cfb11c70 Mon Sep 17 00:00:00 2001 From: Sam Bilbow Date: Thu, 27 Nov 2025 16:32:29 +0000 Subject: [PATCH 2/5] docs: clarify instructions for enabling APIs in Seed Project --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 058fd1c3..9a9e2714 100644 --- a/README.md +++ b/README.md @@ -229,7 +229,7 @@ following roles: A [helper script](./helpers/setup-sa.sh) is included to create the Seed Service Account in the [Seed Project](https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/docs/GLOSSARY.md#seed-project), grant the necessary roles to the [Seed Service Account](https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/docs/GLOSSARY.md#seed-service-account), -and enable the necessary API's in the Seed Project. Run it as follows: +and enable the necessary API's in your Seed Project. Run it as follows: ```sh ./helpers/setup-sa.sh -o -p [-b ] [-f ] [-n ] From acf7ef2452d0fcdf4b9d741c0b37314b6877188d Mon Sep 17 00:00:00 2001 From: Sam Bilbow Date: Thu, 27 Nov 2025 16:33:48 +0000 Subject: [PATCH 3/5] docs: update README to specify enabling APIs in existing Seed Project --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9a9e2714..3e9f632c 100644 --- a/README.md +++ b/README.md @@ -229,7 +229,7 @@ following roles: A [helper script](./helpers/setup-sa.sh) is included to create the Seed Service Account in the [Seed Project](https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/docs/GLOSSARY.md#seed-project), grant the necessary roles to the [Seed Service Account](https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/docs/GLOSSARY.md#seed-service-account), -and enable the necessary API's in your Seed Project. Run it as follows: +and enable the necessary API's in your existing Seed Project. Run it as follows: ```sh ./helpers/setup-sa.sh -o -p [-b ] [-f ] [-n ] From 1f62b96d07aae7bbe168ab0a713774defd737186 Mon Sep 17 00:00:00 2001 From: Sam Bilbow <31018239+sambilbow@users.noreply.github.com> Date: Thu, 27 Nov 2025 16:42:14 +0000 Subject: [PATCH 4/5] fix: pre-fill variables Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- docs/GLOSSARY.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/GLOSSARY.md b/docs/GLOSSARY.md index 3c8b4295..a0b9a000 100644 --- a/docs/GLOSSARY.md +++ b/docs/GLOSSARY.md @@ -10,9 +10,9 @@ create projects with the project factory. For a minimal working example of a seed project, create a project using the following command in the [Cloud Console](https://console.cloud.google.com/) or the [gcloud CLI](https://cloud.google.com/sdk/gcloud): ```bash -export FOLDER_ID="" -export BILLING_ACCOUNT_ID="" -export SEED_PROJECT_ID="" +export FOLDER_ID="" +export BILLING_ACCOUNT_ID="" +export SEED_PROJECT_ID="" gcloud projects create "$SEED_PROJECT_ID" \ --name="$SEED_PROJECT_ID" \ From aad0c852cf7a1ef5412e9c73d969643115051175 Mon Sep 17 00:00:00 2001 From: Sam Bilbow <31018239+sambilbow@users.noreply.github.com> Date: Thu, 27 Nov 2025 16:42:29 +0000 Subject: [PATCH 5/5] fix: grammar in existing documentation Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3e9f632c..ce89e459 100644 --- a/README.md +++ b/README.md @@ -229,7 +229,7 @@ following roles: A [helper script](./helpers/setup-sa.sh) is included to create the Seed Service Account in the [Seed Project](https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/docs/GLOSSARY.md#seed-project), grant the necessary roles to the [Seed Service Account](https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/docs/GLOSSARY.md#seed-service-account), -and enable the necessary API's in your existing Seed Project. Run it as follows: +and enable the necessary APIs in your existing Seed Project. Run it as follows: ```sh ./helpers/setup-sa.sh -o -p [-b ] [-f ] [-n ]