Add more tests

Author: nacx

internal/oidc/session_test.go

@@ -78,7 +78,7 @@ func TestSessionStoreFactory(t *testing.T) {
 		},
 	}
 
-	store := &sessionStoreFactory{Config: config}
+	store := NewSessionStoreFactory(config).(*sessionStoreFactory)
 	g := run.Group{Logger: telemetry.NoopLogger()}
 	g.Register(store)
 	require.NoError(t, g.Run())
@@ -124,3 +124,21 @@ func TestSessionStoreFactoryRedisFails(t *testing.T) {
 	mr.SetError("server error")
 	require.ErrorContains(t, g.Run(), "server error")
 }
+
+func TestSessionGenerator(t *testing.T) {
+	t.Run("random", func(t *testing.T) {
+		sg := NewRandomGenerator()
+		require.NotEqual(t, sg.GenerateSessionID(), sg.GenerateSessionID())
+		require.NotEqual(t, sg.GenerateState(), sg.GenerateState())
+		require.NotEqual(t, sg.GenerateNonce(), sg.GenerateNonce())
+	})
+	t.Run("static", func(t *testing.T) {
+		sg := NewStaticGenerator("sessionid", "nonce", "state")
+		require.Equal(t, sg.GenerateSessionID(), sg.GenerateSessionID())
+		require.Equal(t, sg.GenerateState(), sg.GenerateState())
+		require.Equal(t, sg.GenerateNonce(), sg.GenerateNonce())
+		require.Equal(t, "sessionid", sg.GenerateSessionID())
+		require.Equal(t, "state", sg.GenerateState())
+		require.Equal(t, "nonce", sg.GenerateNonce())
+	})
+}

internal/server/requestid_test.go

@@ -0,0 +1,47 @@
+// Copyright 2024 Tetrate
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package server
+
+import (
+	"context"
+	"testing"
+
+	envoy "github.com/envoyproxy/go-control-plane/envoy/service/auth/v3"
+	"github.com/stretchr/testify/require"
+	"github.com/tetratelabs/telemetry"
+)
+
+func TestPropagateRequestId(t *testing.T) {
+	tests := []struct {
+		name string
+		req  interface{}
+		want []interface{}
+	}{
+		{"not-envoy-request", struct{}{}, nil},
+		{"no-x-request-id", &envoy.CheckRequest{}, nil},
+		{"with-x-request-id", header("test"), []interface{}{EnvoyXRequestID, "test-request-id"}},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			ctx := context.Background()
+			_, _ = PropagateRequestID(ctx, tt.req, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
+				kvs := telemetry.KeyValuesFromContext(ctx)
+				require.Equal(t, tt.want, kvs)
+				return nil, nil
+			})
+		})
+	}
+}