Skip to content
This repository was archived by the owner on Apr 22, 2024. It is now read-only.

Commit 4674174

Browse files
committed
api change
Signed-off-by: huabing zhao <[email protected]>
1 parent f281f16 commit 4674174

File tree

1 file changed

+23
-4
lines changed

1 file changed

+23
-4
lines changed

config/v1/oidc/config.proto

+23-4
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,29 @@ message OIDCConfig {
130130
// Required.
131131
string client_id = 5 [(validate.rules).string.min_len = 1];
132132

133-
// The OIDC client secret assigned to the filter to be used in the
134-
// [Authentication Request](https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest).
135-
// Required.
136-
string client_secret = 6 [(validate.rules).string.min_len = 1];
133+
// This message defines a reference to a Kubernetes Secret resource.
134+
message SecretReference {
135+
// The namespace of the referenced Secret, if not set, default to "default" namespace.
136+
string namespace = 1;
137+
138+
// The name of the referenced Secret.
139+
string name = 2 [(validate.rules).string.min_len = 1];
140+
}
141+
142+
oneof client_secret_config {
143+
// The OIDC client secret assigned to the filter to be used in the
144+
// [Authentication Request](https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest).
145+
// This field keeps the client secret in plain text. Recommend to use `client_secret_ref` instead
146+
// when running in a Kubernetes cluster.
147+
string client_secret = 6;
148+
149+
// The Kubernetes secret that contains the OIDC client secret assigned to the filter to be used in the
150+
// [Authentication Request](https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest).
151+
//
152+
// This is an Opaque secret. The client secret should be stored in the key "client-secret".
153+
// This filed is only valid when running in a Kubernetes cluster.
154+
SecretReference client_secret_ref = 20;
155+
}
137156

138157
// Additional scopes passed to the OIDC Provider in the
139158
// [Authentication Request](https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest).

0 commit comments

Comments
 (0)