Wrong path taken when using packwerk

[Simonpedro]

In our application we have packs and sometimes we colocate specs inside them.

For example, we have the feature spec packs/test_results/spec/features/review_results_spec.rb, but when running it with the extension it tries to execute bundle exec rspec --color spec/features/review_results_spec.rb, omitting the packs/test_results/ part.

I'l be happy to work on this issue if you think it's a legit one. Thanks!

[thadeu]

Hey @Simonpedro Thanks for open this issue.

Interesting use case, I've never see this scene. So, instead app/ or /app/app (like devcontainer) you have packs/.

In theory it will be easy fix it, but I'll create a some tests to cover other prefix like your.

If you free feel, open a PR with this change and I'll accept as soon as.

[Simonpedro]

Thanks for the reply @thadeu. Exactly, since we're using packwerk. Perfect, I'll work on it soon 👍

[traviskroberts]

@Simonpedro Have you had a chance to look into this? I'm running into the same problem.

[Simonpedro]

@traviskroberts I started looking into the code but couldn't find the time to work on it. You're more than welcome to give it a try if you'd like. Otherwise I'll see if I can invest some time next week.

[thadeu]

Ok guys, I think that I'll into the problem today, so I would like to you that waiting for a couple time. I'll fix them soon.

[thadeu]

Hey @Simonpedro do you use devcontainer together? I'm has been difficult to simulate your environment. Can you give me more details? Like as:

Do you se devcontainer?
Do you use workspace single or multiple folders?

I'm imagine that you use uri like /packwerk/packs/test_results/spec/features/review_results_spec.rb

Given that, packwerk is a folder inside root devcontainer and packs maybe be project folder, is that right?

[Simonpedro]

Hey @Simonpedro do you use devcontainer together? I'm has been difficult to simulate your environment. Can you give me more details? Like as:

Do you se devcontainer? Do you use workspace single or multiple folders?

I'm imagine that you use uri like /packwerk/packs/test_results/spec/features/review_results_spec.rb

Given that, packwerk is a folder inside root devcontainer and packs maybe be project folder, is that right?

Hi @thadeu, I'm using VS Code locally. The packs folder is a sibling of app, under to root project directory, and there is no packwerk folder. The file path relative to the project root would be packs/test_results/spec/features/review_results/review_results_spec.rb.

I noticed you opened a PR for this! 🙇

[thadeu]

Hey @Simonpedro do you use devcontainer together? I'm has been difficult to simulate your environment. Can you give me more details? Like as:
Do you se devcontainer? Do you use workspace single or multiple folders?
I'm imagine that you use uri like /packwerk/packs/test_results/spec/features/review_results_spec.rb
Given that, packwerk is a folder inside root devcontainer and packs maybe be project folder, is that right?

Hi @thadeu, I'm using VS Code locally. The packs folder is a sibling of app, under to root project directory, and there is no packwerk folder. The file path relative to the project root would be packs/test_results/spec/features/review_results/review_results_spec.rb.

I noticed you opened a PR for this! 🙇

Ok @Simonpedro I'll run my changes on your file path in order to check if the change will fix this issue.

[alexevanczuk]

Hi all! I am just running into this problem.

We have tests in two places:

1. spec/domain/path/to/something_spec.rb
2. packs/my_pack/spec/domain/path/to/something_spec.rb

Is there a way to configure this extension to simply run the test file that's open, relative to the root directory? Can I turn off the guessing of the folder entirely?

[thadeu]

@alexevanczuk I've a PR working in progress to resolve this issue. I hope next week to release it.

[rsslldnphy]

Hi! Did you get round to making this PR? Am running into the same issue now - we call our folders packages rather than packs - could that be the issue? Thanks :-)