From 634adc93298c4251495d2617d1c18009e5ce497b Mon Sep 17 00:00:00 2001
From: Guillaume <g.alabre@thecodingmachine.com>
Date: Sun, 26 Oct 2025 10:08:30 +0100
Subject: [PATCH] :bug: Throw if we cannot lazy load

Previously we were giving the false impression that it was possible to lazy-load the bean. But we would effectively load it.
---
 ...TDBMCannotLazyLoadInheritanceException.php | 19 +++++++++++++++++++
 src/TDBMService.php                           |  2 ++
 tests/TDBMDaoGeneratorTest.php                |  8 ++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 src/TDBMCannotLazyLoadInheritanceException.php

diff --git a/src/TDBMCannotLazyLoadInheritanceException.php b/src/TDBMCannotLazyLoadInheritanceException.php
new file mode 100644
index 00000000..284c59ec
--- /dev/null
+++ b/src/TDBMCannotLazyLoadInheritanceException.php
@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TheCodingMachine\TDBM;
+
+/**
+ * Exception thrown when TDBM cannot lazy load a bean because this bean is used in inheritance.
+ */
+class TDBMCannotLazyLoadInheritanceException extends TDBMException
+{
+    /**
+     * @param string[] $tables
+     */
+    public static function create(array $tables): TDBMCannotLazyLoadInheritanceException
+    {
+        return new self(sprintf('Failed to lazy load the tables (%s) as they are part of inheritance.', implode(', ', $tables)));
+    }
+}
diff --git a/src/TDBMService.php b/src/TDBMService.php
index bdb6c92c..282f8a29 100644
--- a/src/TDBMService.php
+++ b/src/TDBMService.php
@@ -1253,6 +1253,8 @@ public function findObjectByPk(string $table, array $primaryKeys, array $additio
 
                 return $bean;
             }
+
+            throw TDBMCannotLazyLoadInheritanceException::create($tables);
         }
 
         // Did not find the object in cache? Let's query it!
diff --git a/tests/TDBMDaoGeneratorTest.php b/tests/TDBMDaoGeneratorTest.php
index 9f601f6a..0b9886cf 100644
--- a/tests/TDBMDaoGeneratorTest.php
+++ b/tests/TDBMDaoGeneratorTest.php
@@ -2464,6 +2464,14 @@ public function testHydrateGetByIdAfterLazyLoad(): void
         $this->assertSame(TDBMObjectStateEnum::STATE_LOADED, $country->_getStatus()); // This is failing
     }
 
+    public function testGetByIdLazyLoadFailsOnInheritance(): void
+    {
+        $this->expectException(TDBMCannotLazyLoadInheritanceException::class);
+        $this->expectExceptionMessage('Failed to lazy load the tables (person, contact, users) as they are part of inheritance.');
+        $userDao = new UserDao($this->tdbmService);
+        $userDao->getById(1, true);
+    }
+
     private function skipOracle(): void
     {
         if (self::getConnection()->getDatabasePlatform() instanceof OraclePlatform) {