From c9b546b2bd59f5ec9fb001387df9e62bd38c86b0 Mon Sep 17 00:00:00 2001 From: Gustavo Dupont Date: Wed, 17 Sep 2025 15:14:15 -0700 Subject: [PATCH 1/3] Removing node role from name convention --- aurora-postgres.cfndsl.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/aurora-postgres.cfndsl.rb b/aurora-postgres.cfndsl.rb index d0abced..3c70dd5 100644 --- a/aurora-postgres.cfndsl.rb +++ b/aurora-postgres.cfndsl.rb @@ -221,7 +221,7 @@ writer_maintenance_window = external_parameters.fetch(:writer_maintenance_window, maint_window) if engine_mode == 'serverless' - RDS_DBInstance(:ServerlessDBInstance) { + RDS_DBInstance() { Engine 'aurora-postgresql' DBInstanceClass 'db.serverless' DBClusterIdentifier Ref(:DBCluster) @@ -231,7 +231,7 @@ Condition("CreateReaderRecord", FnAnd([FnEquals(Ref("EnableReader"), 'true'), Condition('CreateHostRecord')])) Condition("EnableReader", FnEquals(Ref("EnableReader"), 'true')) - RDS_DBInstance(:DBClusterInstanceWriter) { + RDS_DBInstance() { DBSubnetGroupName Ref(:DBClusterSubnetGroup) DBParameterGroupName Ref(:DBInstanceParameterGroup) DBClusterIdentifier Ref(:DBCluster) @@ -246,7 +246,7 @@ reader_maintenance_window = external_parameters.fetch(:reader_maintenance_window, nil) - RDS_DBInstance(:DBClusterInstanceReader) { + RDS_DBInstance() { Condition(:EnableReader) DBSubnetGroupName Ref(:DBClusterSubnetGroup) DBParameterGroupName Ref(:DBInstanceParameterGroup) From 5270f0f94349c555a8d9c87b396b86744a1a64fd Mon Sep 17 00:00:00 2001 From: Gustavo Dupont Date: Wed, 17 Sep 2025 15:40:58 -0700 Subject: [PATCH 2/3] test --- aurora-postgres.cfndsl.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/aurora-postgres.cfndsl.rb b/aurora-postgres.cfndsl.rb index 3c70dd5..dd0ef88 100644 --- a/aurora-postgres.cfndsl.rb +++ b/aurora-postgres.cfndsl.rb @@ -221,7 +221,7 @@ writer_maintenance_window = external_parameters.fetch(:writer_maintenance_window, maint_window) if engine_mode == 'serverless' - RDS_DBInstance() { + RDS_DBInstance(:ServerlessDBInstance) { Engine 'aurora-postgresql' DBInstanceClass 'db.serverless' DBClusterIdentifier Ref(:DBCluster) @@ -231,7 +231,7 @@ Condition("CreateReaderRecord", FnAnd([FnEquals(Ref("EnableReader"), 'true'), Condition('CreateHostRecord')])) Condition("EnableReader", FnEquals(Ref("EnableReader"), 'true')) - RDS_DBInstance() { + RDS_DBInstance(:DBClusterInstance) { DBSubnetGroupName Ref(:DBClusterSubnetGroup) DBParameterGroupName Ref(:DBInstanceParameterGroup) DBClusterIdentifier Ref(:DBCluster) @@ -246,7 +246,7 @@ reader_maintenance_window = external_parameters.fetch(:reader_maintenance_window, nil) - RDS_DBInstance() { + RDS_DBInstance(:DBClusterInstance) { Condition(:EnableReader) DBSubnetGroupName Ref(:DBClusterSubnetGroup) DBParameterGroupName Ref(:DBInstanceParameterGroup) From 4bcaed0e63a2a6538340d54cba99c199018936c6 Mon Sep 17 00:00:00 2001 From: Gustavo Dupont Date: Wed, 17 Sep 2025 16:27:46 -0700 Subject: [PATCH 3/3] updating reader node names --- aurora-postgres.cfndsl.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aurora-postgres.cfndsl.rb b/aurora-postgres.cfndsl.rb index dd0ef88..3164cd0 100644 --- a/aurora-postgres.cfndsl.rb +++ b/aurora-postgres.cfndsl.rb @@ -246,7 +246,7 @@ reader_maintenance_window = external_parameters.fetch(:reader_maintenance_window, nil) - RDS_DBInstance(:DBClusterInstance) { + RDS_DBInstance(:DBClusterInstances) { Condition(:EnableReader) DBSubnetGroupName Ref(:DBClusterSubnetGroup) DBParameterGroupName Ref(:DBInstanceParameterGroup)