Update RtMidi.cpp

Fix possible memory management bugs.
Replace one call to CFStringCreateWithCString with just the CFSTR macro.

Author: MaddTheSane

RtMidi.cpp

@@ -1179,7 +1179,7 @@ unsigned int MidiInCore :: getPortCount()
 
 // This function was submitted by Douglas Casey Tucker and apparently
 // derived largely from PortMidi.
-CFStringRef EndpointName( MIDIEndpointRef endpoint, bool isExternal )
+CFStringRef CreateEndpointName( MIDIEndpointRef endpoint, bool isExternal )
 {
   CFMutableStringRef result = CFStringCreateMutable( NULL, 0 );
   CFStringRef str;
@@ -1189,13 +1189,10 @@ CFStringRef EndpointName( MIDIEndpointRef endpoint, bool isExternal )
   MIDIObjectGetStringProperty( endpoint, kMIDIPropertyName, &str );
   if ( str != NULL ) {
     CFStringAppend( result, str );
-    CFRelease( str );
   }
 
   // some MIDI devices have a leading space in endpoint name. trim
-  CFStringRef space = CFStringCreateWithCString(NULL, " ", kCFStringEncodingUTF8);
-  CFStringTrim(result, space);
-  CFRelease(space);
+  CFStringTrim(result, CFSTR(" "));
 
   MIDIEntityRef entity = 0;
   MIDIEndpointGetEntity( endpoint, &entity );
@@ -1209,7 +1206,6 @@ CFStringRef EndpointName( MIDIEndpointRef endpoint, bool isExternal )
     MIDIObjectGetStringProperty( entity, kMIDIPropertyName, &str );
     if ( str != NULL ) {
       CFStringAppend( result, str );
-      CFRelease( str );
     }
   }
   // now consider the device's name
@@ -1222,17 +1218,18 @@ CFStringRef EndpointName( MIDIEndpointRef endpoint, bool isExternal )
   MIDIObjectGetStringProperty( device, kMIDIPropertyName, &str );
   if ( CFStringGetLength( result ) == 0 ) {
       CFRelease( result );
+      CFRetain( str );
       return str;
   }
   if ( str != NULL ) {
     // if an external device has only one entity, throw away
     // the endpoint name and just use the device name
     if ( isExternal && MIDIDeviceGetNumberOfEntities( device ) < 2 ) {
       CFRelease( result );
+      CFRetain( str );
       return str;
     } else {
       if ( CFStringGetLength( str ) == 0 ) {
-        CFRelease( str );
         return result;
       }
       // does the entity name already start with the device name?
@@ -1247,15 +1244,14 @@ CFStringRef EndpointName( MIDIEndpointRef endpoint, bool isExternal )
 
         CFStringInsert( result, 0, str );
       }
-      CFRelease( str );
     }
   }
   return result;
 }
 
 // This function was submitted by Douglas Casey Tucker and apparently
 // derived largely from PortMidi.
-static CFStringRef ConnectedEndpointName( MIDIEndpointRef endpoint )
+static CFStringRef CreateConnectedEndpointName( MIDIEndpointRef endpoint )
 {
   CFMutableStringRef result = CFStringCreateMutable( NULL, 0 );
   CFStringRef str;
@@ -1282,11 +1278,12 @@ static CFStringRef ConnectedEndpointName( MIDIEndpointRef endpoint )
           if ( connObjectType == kMIDIObjectType_ExternalSource  ||
                connObjectType == kMIDIObjectType_ExternalDestination ) {
             // Connected to an external device's endpoint (10.3 and later).
-            str = EndpointName( (MIDIEndpointRef)(connObject), true );
+            str = CreateEndpointName( (MIDIEndpointRef)(connObject), true );
           } else {
             // Connected to an external device (10.2) (or something else, catch-
             str = NULL;
             MIDIObjectGetStringProperty( connObject, kMIDIPropertyName, &str );
+            if ( str ) CFRetain ( str );
           }
           if ( str != NULL ) {
             if ( anyStrings )
@@ -1307,7 +1304,7 @@ static CFStringRef ConnectedEndpointName( MIDIEndpointRef endpoint )
   CFRelease( result );
 
   // Here, either the endpoint had no connections, or we failed to obtain names
-  return EndpointName( endpoint, false );
+  return CreateEndpointName( endpoint, false );
 }
 
 std::string MidiInCore :: getPortName( unsigned int portNumber )
@@ -1327,7 +1324,7 @@ std::string MidiInCore :: getPortName( unsigned int portNumber )
   }
 
   portRef = MIDIGetSource( portNumber );
-  nameRef = ConnectedEndpointName( portRef );
+  nameRef = CreateConnectedEndpointName( portRef );
   CFStringGetCString( nameRef, name, sizeof(name), kCFStringEncodingUTF8 );
   CFRelease( nameRef );
 
@@ -1414,7 +1411,7 @@ std::string MidiOutCore :: getPortName( unsigned int portNumber )
   }
 
   portRef = MIDIGetDestination( portNumber );
-  nameRef = ConnectedEndpointName(portRef);
+  nameRef = CreateConnectedEndpointName(portRef);
   CFStringGetCString( nameRef, name, sizeof(name), kCFStringEncodingUTF8 );
   CFRelease( nameRef );