-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0 release #142
Comments
👍🏻
|
As #130 has stalled for the past months, I'd suggest releasing 2.8.0 including the commits since March 2017. |
Good idea. I can ship it out tomorrow evening (I might need to update some
of the scrapers).
…On Sun, Aug 6, 2017 at 11:42 AM, Thibaud Guillaume-Gentil < ***@***.***> wrote:
@maia <https://github.com/maia> that's fine for me, I let @vheuken
<https://github.com/vheuken> take the final decision.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#142 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAs5GGq2PlJY-FvvPA5PtiSgqyQZng49ks5sVgkhgaJpZM4HvlVa>
.
--
Vincent Heuken
|
Sorry, scratch that. I'll do it this weekend.
…On Sun, Aug 6, 2017 at 3:36 PM, Vincent Heuken ***@***.***> wrote:
Good idea. I can ship it out tomorrow evening (I might need to update some
of the scrapers).
On Sun, Aug 6, 2017 at 11:42 AM, Thibaud Guillaume-Gentil <
***@***.***> wrote:
> @maia <https://github.com/maia> that's fine for me, I let @vheuken
> <https://github.com/vheuken> take the final decision.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#142 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAs5GGq2PlJY-FvvPA5PtiSgqyQZng49ks5sVgkhgaJpZM4HvlVa>
> .
>
--
Vincent Heuken
--
Vincent Heuken
|
Looks like VK is broken, along with a few other tests. I'll need to fix that before pushing a new version. I'll try my best to get to it over the next couple days. |
@vheuken I could try to look at VK at this sunday |
@drakmail That would be awesome! I think it might just be some test URLs that need to be updated. |
@thibaudgg @vheuken time to close this one? v3 is out since Nov 7, 2020 (https://github.com/thibaudgg/video_info/releases/tag/v3.0.0) |
Sure! |
I think once #130 is implemented we can release
3.0.0
.Current changelog:
#author
,#author_url
, and#author_thumbnail
implementedVkontakte#keywords
now returnsnil
Vimeo#keywords
returns an array instead of a stringTODO:
#thumbnail
methodThe text was updated successfully, but these errors were encountered: