Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing more video statistics #188

Closed
ishields opened this issue Apr 6, 2020 · 4 comments · Fixed by #220
Closed

Exposing more video statistics #188

ishields opened this issue Apr 6, 2020 · 4 comments · Fixed by #220
Labels

Comments

@ishields
Copy link
Contributor

ishields commented Apr 6, 2020

Would it make sense to expose more statistics so they can be used when available?
The YouTube api returns a lot more useful statistics than what is available via the model (because the _video_statistics attribute is private).

 {"viewCount"=>"1036033", "likeCount"=>"27742", "dislikeCount"=>"1160", "favoriteCount"=>"0", "commentCount"=>"1134"}

Either these raw statistics could be available as a hash or as separate methods. Any thoughts?

@thibaudgg
Copy link
Owner

That sounds good to add, please feel free to open a pull request.

@ishields
Copy link
Contributor Author

ishields commented Apr 6, 2020

Do you have a preference on whether to just expose "video_stats" or do individual methods for each statistic type?

@thibaudgg
Copy link
Owner

I think video_stats should be enough to expose.

@markets
Copy link
Collaborator

markets commented Mar 8, 2023

@ishields I just send a PR 👉🏼 #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants