Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YouTube provider does not fetch standard #191

Closed
ishields opened this issue Apr 8, 2020 · 4 comments
Closed

YouTube provider does not fetch standard #191

ishields opened this issue Apr 8, 2020 · 4 comments

Comments

@ishields
Copy link
Contributor

ishields commented Apr 8, 2020 •
edited
Loading

The thumbnail_large method for the YouTube provider returns an image who's size is only 480x360
ex: https://i.ytimg.com/vi/cDmyGzFHMsE/hqdefault.jpg

The YouTube api returns an additional size of image that isn't accssible.
ex standard: https://i.ytimg.com/vi/cDmyGzFHMsE/sddefault.jpg

I think we need to add an additional thumbnail size.

thumbnail_large_2x

For other providers I will simply return the large thumbnail.
@ishields ishields changed the title YouTube provider does not fetch standard and maxres images YouTube provider does not fetch standard Apr 8, 2020
@ishields
Copy link
Contributor Author

ishields commented Apr 8, 2020 •
edited
Loading

I was mistaken. There is only one missing size - standard. Updated ticket.

@thibaudgg
Copy link
Owner

Sure, I think that would be good to add, PR always appreciated 👍

@ishields ishields mentioned this issue Apr 8, 2020
Merged
@ishields
Copy link
Contributor Author

Is the plan to make a release for these two most recent fixes?

@thibaudgg
Copy link
Owner

I have just released version 2.8, thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thibaudgg @ishields