Improve performance of usable? helper

[markets]

All providers define this method:

def self.usable?(url)
  url ~= /PROVIDER_REGEX/
end

Since we don't need matches and it's defined as a predicate method, I think we should switch to String#match? or Regexp#match? in those methods for speed (https://github.com/fastruby/fast-ruby#stringmatch-vs-stringmatch-vs-stringstart_withstringend_with-code-start-code-end):

def self.usable?(url)
  url.match? /PROVIDER_REGEX/
end

What do you think @thibaudgg?

[thibaudgg]

Sure thing, please feel free to open a PR. 👍🏻

[markets]

@thibaudgg here you go 👉🏼 #210

(We should fix the build someday 🙏🏼, now it complicates contributing to this useful project... I'd take this task, but unfortunately I have no experience with VCR 😅)

[thibaudgg]

Yeah, the main issue is that VCR is configured to re-record the cassette (request mock) after a specified amount of time. Here it seems that most provider slightly changed their response so a lot of specs must be fixed. This is certainly a good opportunity to improve the specs base. It would be great if you can look at it, I can assist if you have some questions about VCR.

[markets]

Hey @thibaudgg 👋🏼 if you (or somebody that implemented this part) can fix 1 provider as an example, I'll finish the job! That would be super helpful 🤝

Thanks!

[thibaudgg]

What you could do is remove all the registered cassettes and fix the broken specs from there one by one. Sadly I will not have the time to look at it in the near future.