use provider to get balance and address -> getAddress() (#441)

* use provider to get balance and address -> getAddress()

* udpate tests

* v2.3.5-0

Author: jnsdls

docs/sdk.userwallet.address.md renamed to docs/sdk.userwallet.getaddress.md

@@ -1,15 +1,15 @@
 <!-- Do not edit this file. It is automatically generated by API Documenter. -->
 
-[Home](./index.md) &gt; [@thirdweb-dev/sdk](./sdk.md) &gt; [UserWallet](./sdk.userwallet.md) &gt; [address](./sdk.userwallet.address.md)
+[Home](./index.md) &gt; [@thirdweb-dev/sdk](./sdk.md) &gt; [UserWallet](./sdk.userwallet.md) &gt; [getAddress](./sdk.userwallet.getaddress.md)
 
-## UserWallet.address() method
+## UserWallet.getAddress() method
 
 Get the currently connected address
 
 <b>Signature:</b>
 
 ```typescript
-address(): Promise<string>;
+getAddress(): Promise<string>;
 ```
 <b>Returns:</b>
 
@@ -19,6 +19,6 @@ Promise&lt;string&gt;
 
 
 ```javascript
-const address = await sdk.wallet.address();
+const address = await sdk.wallet.getAddress();
 ```
 

docs/sdk.userwallet.md

@@ -29,8 +29,8 @@ const balance = await sdk.wallet.balance();
 
 |  Method | Modifiers | Description |
 |  --- | --- | --- |
-|  [address()](./sdk.userwallet.address.md) |  | Get the currently connected address |
 |  [balance(currencyAddress)](./sdk.userwallet.balance.md) |  | Fetch the native or ERC20 token balance of this wallet |
+|  [getAddress()](./sdk.userwallet.getaddress.md) |  | Get the currently connected address |
 |  [onNetworkUpdated(network)](./sdk.userwallet.onnetworkupdated.md) |  |  |
 |  [sendRawTransaction(transactionRequest)](./sdk.userwallet.sendrawtransaction.md) |  | Send a raw transaction to the blockchain from the connected wallet |
 |  [sign(message)](./sdk.userwallet.sign.md) |  | Sign any message with the connected wallet private key |

etc/sdk.api.md

@@ -5313,8 +5313,8 @@ export type UploadResult = {
 // @public
 export class UserWallet {
     constructor(network: NetworkOrSignerOrProvider, options: SDKOptions);
-    address(): Promise<string>;
     balance(currencyAddress?: string): Promise<CurrencyValue>;
+    getAddress(): Promise<string>;
     // (undocumented)
     onNetworkUpdated(network: NetworkOrSignerOrProvider): void;
     sendRawTransaction(transactionRequest: providers.TransactionRequest): Promise<TransactionResult>;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thirdweb-dev/sdk",
-  "version": "2.3.4",
+  "version": "2.3.5-0",
   "description": "The main thirdweb SDK.",
   "repository": {
     "type": "git",

src/core/wallet/UserWallet.ts

@@ -105,29 +105,26 @@ export class UserWallet {
   ): Promise<CurrencyValue> {
     const signer = this.connection.getSigner();
     invariant(signer, "Wallet not connected");
+    const provider = this.connection.getProvider();
     let balance: BigNumber;
     if (isNativeToken(currencyAddress)) {
-      balance = await signer.getBalance();
+      balance = await provider.getBalance(await this.getAddress());
     } else {
       balance = await this.createErc20(currencyAddress).readContract.balanceOf(
-        await this.address(),
+        await this.getAddress(),
       );
     }
-    return await fetchCurrencyValue(
-      this.connection.getProvider(),
-      currencyAddress,
-      balance,
-    );
+    return await fetchCurrencyValue(provider, currencyAddress, balance);
   }
 
   /**
    * Get the currently connected address
    * @example
    * ```javascript
-   * const address = await sdk.wallet.address();
+   * const address = await sdk.wallet.getAddress();
    * ```
    */
-  async address(): Promise<string> {
+  async getAddress(): Promise<string> {
     return await this.connectedWallet().getAddress();
   }
 

test/wallet.test.ts

@@ -44,8 +44,8 @@ describe("Wallet", async () => {
 
   it("should fetch addresses", async () => {
     sdk.updateSignerOrProvider(adminWallet);
-    expect(await sdk.wallet.address()).to.eq(adminWallet.address);
+    expect(await sdk.wallet.getAddress()).to.eq(adminWallet.address);
     sdk.updateSignerOrProvider(samWallet);
-    expect(await sdk.wallet.address()).to.eq(samWallet.address);
+    expect(await sdk.wallet.getAddress()).to.eq(samWallet.address);
   });
 });