Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black settings #42

Closed
hissssst opened this issue Jul 27, 2020 · 3 comments
Closed

Black settings #42

hissssst opened this issue Jul 27, 2020 · 3 comments
Assignees

Comments

@hissssst
Copy link

Description

Settings page font (or maybe all page) is black.

Desired behaviour

It would be nice to have some readable text

Actual behaviour

scrot_200727230036

Steps to reproduce

Clone master
Follow quickstart guide
Open settings

Enviroment

ChromeDriver 83.0.4103.116 (8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716})
@cookiengineer
Copy link
Member

Yes, this is correct.

Currently, the stealth:settings are broken due to a Design/UI Refactor that's been going on since the Element/Widget API refactor ( 40e9efc ) that led to a cleaner element-driven design across the Browser UI.

So far, most of the Browser's Main UI has been ported to the new Widget API (appbar, backdrop, sheet, menu etc.) though the Elements necessary for the Service integration are still missing.

I've opened up an issue that's tracking this at #44

@cookiengineer
Copy link
Member

Currently, the stealth:settings are broken due to an ongoing refactor since the Element/Widget API change (somewhere around 40e9efc ) that led to a cleaner element-driven design across the Browser UI.

So far, most of the Browser's Main UI has been ported to the new Widget API (meaning the appbar, backdrop, menu, sheet Widgets with exception to the Webview's dispatch() handler for Context Menu integration) though the ones necessary for the Stealth Service are still missing.

As the new UI will have a Redux-like state management, most parts of the old settings page will get unnecessary as those Widgets will manage their states themselves, so that outside cache/settings management isn't necessary anymore.

I've opened up an issue that's tracking the UI refactor progress at #44

@cookiengineer cookiengineer added the bug A nasty bug has hidden itself in the codebase. label Jul 28, 2020
@cookiengineer
Copy link
Member

As of eb66b39 most parts of the Settings have been migrated.

The Session card and Tab card doesn't work yet, but is tracked in another issue.

@cookiengineer cookiengineer removed the bug A nasty bug has hidden itself in the codebase. label Sep 20, 2020
@cookiengineer cookiengineer added this to the X0 - Codename Spirit milestone Sep 20, 2020
@cookiengineer cookiengineer self-assigned this Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants