fix: several problems with checkboxes

Author: modelrailroader

phpmyfaq/admin/assets/src/content/overview.js

@@ -63,6 +63,8 @@ export const handleFaqOverview = async () => {
               checkbox.checked = element.checked;
               if (checkbox.checked === true) {
                 faqIds.push(checkbox.getAttribute('data-pmf-faq-id'));
+              } else {
+                faqIds.push(checkbox.getAttribute('data-pmf-faq-id'));
               }
             }
           });
@@ -91,9 +93,6 @@ export const handleFaqOverview = async () => {
       element.addEventListener('change', (event) => {
         event.preventDefault();
 
-        console.log(event.target);
-        console.log('toggle active faqs');
-
         const categoryId = event.target.getAttribute('data-pmf-category-id');
         const faqIds = [];
         const token = event.target.getAttribute('data-pmf-csrf');
@@ -105,6 +104,8 @@ export const handleFaqOverview = async () => {
               checkbox.checked = element.checked;
               if (checkbox.checked === true) {
                 faqIds.push(checkbox.getAttribute('data-pmf-faq-id'));
+              } else {
+                faqIds.push(checkbox.getAttribute('data-pmf-faq-id'));
               }
             }
           });

phpmyfaq/admin/record.show.php

@@ -105,6 +105,7 @@
     $numRecordsByCat = $categoryRelation->getNumberOfFaqsPerCategory();
 
     $numActiveByCat = [];
+    $numStickyByCat = [];
 
     $csrfToken = Token::getInstance()->getTokenString('faq-overview');
 
@@ -134,7 +135,11 @@
             if (!isset($numActiveByCat[$record['category_id']])) {
                 $numActiveByCat[$record['category_id']] = 0;
             }
+            if (!isset($numStickyByCat[$record['category_id']])) {
+                $numStickyByCat[$record['category_id']] = 0;
+            }
             $numActiveByCat[$record['category_id']] += $record['active'] == 'yes' ? 1 : 0;
+            $numStickyByCat[$record['category_id']] += $record['sticky'];
         }
     } else {
         $fdTable = Database::getTablePrefix() . 'faqdata';
@@ -324,7 +329,15 @@
                       <div class="form-check">
                         <input class="form-check-input pmf-admin-faqs-all-sticky" type="checkbox" value=""
                                data-pmf-category-id="<?= $cid ?>" data-pmf-csrf="<?= $csrfToken ?>"
-                               id="sticky_category_block_<?= $cid ?>">
+                               id="sticky_category_block_<?= $cid ?>"
+                            <?php
+                            if (
+                                isset($numRecordsByCat[$cid]) && isset($numStickyByCat[$cid]) &&
+                                $numRecordsByCat[$cid] === $numStickyByCat[$cid]
+                            ) {
+                                echo 'checked';
+                            }
+                            ?>>
                         <label class="form-check-label" for="sticky_category_block_<?= $cid ?>">
                           <?= Translation::get('ad_record_sticky') ?>
                         </label>