Skip to content

Commit 80c5d9a

Browse files
committed
feat(http-client): added timeout of 30 sec
1 parent edfc777 commit 80c5d9a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

phpmyfaq/src/phpMyFAQ/Administration/Api.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class Api
4949
*/
5050
public function __construct(private readonly Configuration $configuration)
5151
{
52-
$this->setHttpClient(HttpClient::create(['max_redirects' => 2]));
52+
$this->setHttpClient(HttpClient::create(['max_redirects' => 2, 'timeout' => 30]));
5353
}
5454

5555
/**

phpmyfaq/src/phpMyFAQ/Controller/Administration/UpdateController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public function versions(): JsonResponse
8585
$this->userIsAuthenticated();
8686

8787
try {
88-
$versions = HttpClient::create()->request(
88+
$versions = HttpClient::create(['timeout' => 30])->request(
8989
'GET',
9090
'https://api.phpmyfaq.de/versions'
9191
);

phpmyfaq/src/phpMyFAQ/Setup/Upgrade.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public function downloadPackage(string $version): string
137137
{
138138
$url = $this->getDownloadHost() . $this->getPath() . $this->getFilename($version);
139139

140-
$client = HttpClient::create();
140+
$client = HttpClient::create(['timeout' => 30]);
141141

142142
try {
143143
$response = $client->request('GET', $url);
@@ -170,7 +170,7 @@ public function downloadPackage(string $version): string
170170
*/
171171
public function verifyPackage(string $path, string $version): bool
172172
{
173-
$httpClient = HttpClient::create();
173+
$httpClient = HttpClient::create(['timeout' => 30]);
174174
$response = $httpClient->request(
175175
'GET',
176176
DownloadHostType::PHPMYFAQ->value . 'info/' . $version

0 commit comments

Comments
 (0)