refactor: more code improvements for the category class

Author: thorsten

phpmyfaq/index.php

@@ -438,13 +438,13 @@
     $category->expandTo($cat);
 }
 
-if (isset($cat) && ($cat !== 0) && ($id === 0) && isset($category->categoryName[$cat]['name'])) {
+if (isset($cat) && ($cat !== 0) && ($id === 0) && $category->getCategoryName($cat) !== null) {
     $seoEntity
         ->setSeoType(SeoType::CATEGORY)
         ->setReferenceId($cat);
     $seoData = $seo->get($seoEntity);
-    $title = $seoData->getTitle() ?? $category->categoryName[$cat]['name'];
-    $metaDescription = $seoData->getDescription() ?? $category->categoryName[$cat]['description'];
+    $title = $seoData->getTitle() ?? $category->getCategoryName($cat);
+    $metaDescription = $seoData->getDescription() ?? $category->getCategoryDescription($cat);
 }
 
 //

phpmyfaq/show.php

@@ -45,7 +45,7 @@
     $selectedCategoryId = null;
 }
 
-if (!is_null($selectedCategoryId) && !isset($category->categoryName[$selectedCategoryId])) {
+if (!is_null($selectedCategoryId) && !isset($category->getCategoryName($selectedCategoryId))) {
     $response = new Response();
     $response->setStatusCode(Response::HTTP_NOT_FOUND);
 }
@@ -56,7 +56,7 @@
 $twig = new TwigWrapper(PMF_ROOT_DIR . '/assets/templates/');
 $twigTemplate = $twig->loadTemplate('./show.twig');
 
-if (!is_null($selectedCategoryId) && isset($category->categoryName[$selectedCategoryId])) {
+if (!is_null($selectedCategoryId) && isset($category->getCategoryName($selectedCategoryId))) {
     $faqSession->userTracking('show_category', $selectedCategoryId);
 
     $categoryData = $category->getCategoryData($selectedCategoryId);
@@ -96,7 +96,7 @@
             $sids,
             $categoryData->getParentId()
         );
-        $text = $category->categoryName[$categoryData->getParentId()]['name'] ?? Translation::get('msgCategoryUp');
+        $text = $category->getCategoryName($categoryData->getParentId()) ?? Translation::get('msgCategoryUp');
 
         $link = new Link($url, $faqConfig);
         $link->itemTitle = $text;