refactor: improved code

thorsten · thorsten · commit c5b5f108b29d · 2024-10-19T11:26:37.000+02:00
diff --git a/phpmyfaq/admin/record.edit.php b/phpmyfaq/admin/record.edit.php
@@ -221,7 +221,7 @@
 
     // Group permissions
     $groupPermission = $faqPermission->get(FaqPermission::GROUP, $faqData['id']);
-    if (count($groupPermission) == 0 || $groupPermission[0] == -1) {
+    if (empty($groupPermission) || in_array(-1, $groupPermission, true)) {
         $allGroups = true;
         $restrictedGroups = false;
         $groupPermission[0] = -1;
diff --git a/phpmyfaq/src/phpMyFAQ/Faq/FaqPermission.php b/phpmyfaq/src/phpMyFAQ/Faq/FaqPermission.php
@@ -87,9 +87,8 @@ public function delete(string $mode, int $faqId): bool
             $mode,
             $faqId
         );
-        $this->config->getDb()->query($query);
 
-        return true;
+        return (bool) $this->config->getDb()->query($query);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -87,9 +87,8 @@ public function delete(string $mode, int $faqId): bool`
`87`	`87`	`$mode,`
`88`	`88`	`$faqId`
`89`	`89`	`);`
`90`		`- $this->config->getDb()->query($query);`
`91`	`90`
`92`		`- return true;`
	`91`	`+ return (bool) $this->config->getDb()->query($query);`
`93`	`92`	`}`
`94`	`93`
`95`	`94`	`/**`