fix: Windows path handling - replace hardcoded forward slashes with Node.js path module

This commit fixes Windows compatibility issues caused by hardcoded forward slash (/) path separators. The changes ensure proper path handling across both Windows and Unix-like systems.

Changes:
- src/services/embedding.ts: Use path.join() for cache directory path
- src/services/sqlite/connection-manager.ts: Use path.dirname() instead of lastIndexOf('/')
- src/services/tags.ts: Use path.sep and path.normalize() for cross-platform path handling
- src/web/app.js: Normalize Windows backslashes before splitting paths
- tests/windows-path.test.ts: Add comprehensive tests for Windows path handling

All existing tests pass (13 tests), and new tests verify correct behavior on both Windows and Unix paths.

Author: cacaview

src/services/embedding.ts

@@ -1,10 +1,11 @@
 import { pipeline, env } from "@xenova/transformers";
 import { CONFIG } from "../config.js";
 import { log } from "./logger.js";
+import { join } from "node:path";
 
 env.allowLocalModels = true;
 env.allowRemoteModels = true;
-env.cacheDir = CONFIG.storagePath + "/.cache";
+env.cacheDir = join(CONFIG.storagePath, ".cache");
 
 const TIMEOUT_MS = 30000;
 const GLOBAL_EMBEDDING_KEY = Symbol.for("opencode-mem.embedding.instance");

src/services/sqlite/connection-manager.ts

@@ -1,6 +1,7 @@
 import { Database } from "bun:sqlite";
 import * as sqliteVec from "sqlite-vec";
 import { existsSync, mkdirSync } from "node:fs";
+import { dirname } from "node:path";
 import { log } from "../logger.js";
 import { CONFIG } from "../../config.js";
 
@@ -98,14 +99,14 @@ export class ConnectionManager {
     }
   }
 
-  getConnection(dbPath: string): Database {
+getConnection(dbPath: string): Database {
     if (this.connections.has(dbPath)) {
       return this.connections.get(dbPath)!;
     }
 
     this.configureSqlite();
 
-    const dir = dbPath.substring(0, dbPath.lastIndexOf("/"));
+    const dir = dirname(dbPath);
     if (!existsSync(dir)) {
       mkdirSync(dir, { recursive: true });
     }

src/services/tags.ts

@@ -1,6 +1,7 @@
 import { createHash } from "node:crypto";
 import { execSync } from "node:child_process";
 import { CONFIG } from "../config.js";
+import { sep, normalize } from "node:path";
 
 function sha256(input: string): string {
   return createHash("sha256").update(input).digest("hex").slice(0, 16);
@@ -47,7 +48,9 @@ export function getGitRepoUrl(directory: string): string | null {
 }
 
 export function getProjectName(directory: string): string {
-  const parts = directory.split("/").filter((p) => p);
+  // Normalize path to handle both Unix and Windows separators
+  const normalized = normalize(directory);
+  const parts = normalized.split(sep).filter((p) => p);
   return parts[parts.length - 1] || directory;
 }
 

src/web/app.js

@@ -171,9 +171,9 @@ function renderMemoryCard(memory) {
       ? `<span class="similarity-score">${memory.similarity}%</span>`
       : "";
 
-  let displayInfo = memory.displayName || memory.id;
+let displayInfo = memory.displayName || memory.id;
   if (memory.projectPath) {
-    const pathParts = memory.projectPath.split("/");
+    const pathParts = memory.projectPath.replace(/\\/g, "/").split("/").filter((p) => p);
     displayInfo = pathParts[pathParts.length - 1] || memory.projectPath;
   }
 

tests/windows-path.test.ts

@@ -0,0 +1,93 @@
+import { describe, it, expect } from "bun:test";
+import { getProjectName } from "../src/services/tags.js";
+import { dirname } from "node:path";
+import { join } from "node:path";
+import * as fs from "node:fs";
+
+describe("Windows Path Handling", () => {
+  describe("getProjectName", () => {
+    it("should handle Unix-style paths correctly", () => {
+      const result = getProjectName("/home/user/projects/my-project");
+      expect(result).toBe("my-project");
+    });
+
+    it("should handle Windows-style paths correctly", () => {
+      const result = getProjectName("C:\\Users\\user\\projects\\my-project");
+      expect(result).toBe("my-project");
+    });
+
+    it("should handle Windows-style paths with forward slashes", () => {
+      const result = getProjectName("C:/Users/user/projects/my-project");
+      expect(result).toBe("my-project");
+    });
+
+    it("should handle relative Windows paths", () => {
+      const result = getProjectName("..\\projects\\my-project");
+      expect(result).toBe("my-project");
+    });
+
+    it("should return the input if no path separators found", () => {
+      const result = getProjectName("my-project");
+      expect(result).toBe("my-project");
+    });
+  });
+
+  describe("path.join for cache directory", () => {
+    it("should join paths correctly on Windows", () => {
+      const storagePath = "C:\\Users\\user\\.opencode-mem";
+      const cacheDir = join(storagePath, ".cache");
+      expect(cacheDir).toContain(".cache");
+      expect(cacheDir).not.toContain("//");
+    });
+
+    it("should join paths correctly on Unix", () => {
+      const storagePath = "/home/user/.opencode-mem";
+      const cacheDir = join(storagePath, ".cache");
+      expect(cacheDir).toContain(".cache");
+      expect(cacheDir).not.toContain("//");
+    });
+  });
+
+  describe("dirname for database path", () => {
+    it("should extract directory correctly from Windows path", () => {
+      const dbPath = "C:\\Users\\user\\.opencode-mem\\shards\\project.db";
+      const dir = dirname(dbPath);
+      expect(dir).toBe("C:\\Users\\user\\.opencode-mem\\shards");
+    });
+
+    it("should extract directory correctly from Unix path", () => {
+      const dbPath = "/home/user/.opencode-mem/shards/project.db";
+      const dir = dirname(dbPath);
+      expect(dir).toBe("/home/user/.opencode-mem/shards");
+    });
+
+    it("should handle paths with mixed separators", () => {
+      const dbPath = "C:\\Users\\user/.opencode-mem\\shards/project.db";
+      const dir = dirname(dbPath);
+      expect(dir).toContain("shards");
+    });
+  });
+
+  describe("Web UI path normalization", () => {
+    it("should normalize Windows backslashes to forward slashes", () => {
+      const projectPath = "C:\\Users\\user\\projects\\my-project";
+      const normalized = projectPath.replace(/\\/g, "/");
+      const parts = normalized.split("/").filter((p) => p);
+      expect(parts[parts.length - 1]).toBe("my-project");
+    });
+
+    it("should handle Unix paths without modification", () => {
+      const projectPath = "/home/user/projects/my-project";
+      const normalized = projectPath.replace(/\\/g, "/");
+      const parts = normalized.split("/").filter((p) => p);
+      expect(parts[parts.length - 1]).toBe("my-project");
+    });
+
+    it("should handle mixed path separators", () => {
+      const projectPath = "C:\\Users/user/projects\\my-project";
+      const normalized = projectPath.replace(/\\/g, "/");
+      const parts = normalized.split("/").filter((p) => p);
+      expect(parts[parts.length - 1]).toBe("my-project");
+    });
+  });
+});