-
Notifications
You must be signed in to change notification settings - Fork 195
Add functions: str_to_pascal(), str_to_camel(), str_to_kebab(), str_to_snake()
#577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CC: @kbodwin |
|
Sorry for missing this. Are you still interested in finishing it off? No problems if not, as I'm happy to do it myself. |
|
We're happy to make changes if needed! But I'm not sure I see what's missing - do you see something more you'd want for this to be ready for review? |
R/case.R
Outdated
| #' each word is capitalized. | ||
| #' * `str_to_sentence()` convert to sentence case, where only the first letter | ||
| #' of sentence is capitalized. | ||
| #' * `str_to_pascal()` converts to pascal case, where only the first letter of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure Pascal case is particularly well known (at least I didn't recognise it) so how about it make it an argument to str_camel_case(), e.g. first_upper = TRUE?
R/case.R
Outdated
| strToCamel <- str_to_camel | ||
| #' @export | ||
| #' @rdname case | ||
| str_to_snake <- function(string, separator = "_", locale = "en") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could eliminate the separator argument by creating an internal function that both snake and kebab case uses.
Added 4 functions for common programming use. Closes #573 .
All functions call an existing
str_to_*()so locale argument respects the behavior of those functionsAliases
StrToPascal()andstrToCamel()exist (str-to-kebab()is not a valid name)