New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing check store state when get tiflash_mpp info #533

Open

guo-shaoge opened this issue Jun 23, 2022 · 1 comment

Assignees

Contributor

guo-shaoge commented Jun 23, 2022

client-go/internal/locate/region_cache.go

Line 1832 in 681fb6e

    
           if isStoreContainLabel(s.GetLabels(), tikvrpc.EngineLabelKey, tikvrpc.EngineLabelTiFlashMPP) {

Should also check store.state, otherwise may get tomestone or offline store. (s.GetState() == metapb.StoreState_Up)

Contributor Author

guo-shaoge commented Jun 23, 2022

/assign @guo-shaoge

disksing assigned guo-shaoge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment