-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination to the tags page #869
Comments
Thanks for raising this issue. Your code seems ok to me except the pagination is in decimal points which resulted in the last page not being able to show. I have fixed it by including Math.ceil in the return code for the getTotalPages function. |
Ah good catch. Thanks! |
Hi! I made a similar proposal a few months ago for my i18n version. And I finally just got to work and so I coded it! Being an i18n version, this requires some adaptations for the normal version, but in any case it works :) |
Since the blog page has pagination, the tags should also paginate to keep the same functionality in that page.
I did something similar to my site: Adriel-M/adriel.dev#80 (no demo on my actual site since I don't have enough posts 😓 )
I had to:
ListLayout
ListLayoutWithTags.tsx
to handle finding out current tag and the base path since there's multiple levels now.Let me know if this is something wanted and I can try sending a PR
The text was updated successfully, but these errors were encountered: