Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any thoughts about incorporating CSJS? #38

Open
drcmda opened this issue Nov 20, 2016 · 5 comments
Open

Any thoughts about incorporating CSJS? #38

drcmda opened this issue Nov 20, 2016 · 5 comments

Comments

@drcmda
Copy link
Collaborator

drcmda commented Nov 20, 2016

I noticed CSJS hasn't been updated for months now, important features (like noScope) haven't been published. Npm is outdated, issues aren't answered. Right now i pull CSJS from Github, otherwise i wouldn't be able to create global styles. I noticed there are some other open tickets that haven't been addressed, like extended CSS.

From what i have seen and tried, these two projects, CSJS and ReactCSJS are literally the only ones solving Reacts styling issues. They haven't gotten the attention they deserve (yet?) but i feel like there is something we could maybe do about it.

  1. Move CSJS in here, as a fork so ReactCSJS has zero dependencies.

  2. Make it a focussed React only project.

  3. Trim fat should there be any, bring it to the latest state.

  4. Create front-page tutorials that are easy to digest: scoped, no-scoped, tagged, decorated, how to apply post processing.

  5. Create a recognizable brand.

  6. Publish and introduce on Reddit, Medium, HN, etc, to attract devs that can help developing this.

Any thoughts about this?

@tizmagik
Copy link
Owner

I would be up for that. I do wonder why CSJS itself hasn't seen much activity lately and would like to reach out to @rtsao to see what's up.

Either way though, I do think having react-csjs have zero dependencies by bringing CSJS in here would be great for the user API. This would also help us solve #2 .

I think the steps that you've outlined, in that order, make a lot of sense and I would be happy to support this. Let's start with moving CSJS in here and release a new version of react-csjs with zero dependencies.

Thanks for this @drcmda ! @wKovacs64 any additional thoughts on this?

@wKovacs64
Copy link
Collaborator

I'd like to hear what @rtsao has planned for CSJS, too. I'll admit it appears neglected if not abandoned (which is strange, given its his most popular repository by far). Depending on what he says, I think the overall proposal here could be good if we feel we have the time available to execute it.

Are you guys envisioning a scenario where we attempt to stay current with upstream CSJS (in the event its development picks up again) or a complete divergence from it once we're done integrating?

@tizmagik
Copy link
Owner

tizmagik commented Nov 27, 2016

Submitted issue to CSJS: rtsao/csjs#67

Please feel free to chime in with any other comments/questions/suggestions.

@tizmagik
Copy link
Owner

@wKovacs64 @drcmda reactions to rtsao's reply?

@wKovacs64
Copy link
Collaborator

@tizmagik Well, you got him to acknowledge the lack of movement in CSJS, so that's good. Sounds like he has some good stuff planned for 2.x. If that's imminent, I'd think we'd want to wait for that - but if it's a long way off, I don't know. Your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants