Increased test coverage.

Author: Tonye Jack

dynamic_validator/tests.py

@@ -12,7 +12,32 @@ def setUpTestData(cls):
         )
         cls.user = User.objects.create(username="test-user")
 
-    def test_conditional_required_fields_raises_exception(self):
+    def test_conditional_required_field_raises_exception_when_missing(self):
+        from demo.models import TestModel
+
+        TestModel.CONDITIONAL_REQUIRED_FIELDS = [
+            (
+                lambda instance: instance.user.is_active,
+                ["percentage"],
+            ),
+        ]
+
+        with self.assertRaises(ValueError):
+            TestModel.objects.create(user=self.user)
+
+    def test_conditional_required_field_is_valid(self):
+        from demo.models import TestModel
+
+        TestModel.CONDITIONAL_REQUIRED_FIELDS = [
+            (
+                lambda instance: instance.user.is_active,
+                ["percentage"],
+            ),
+        ]
+
+        TestModel.objects.create(user=self.user, percentage=25)
+    
+    def test_conditional_required_toggle_field_raises_exception_when_missing(self):
         from demo.models import TestModel
 
         TestModel.CONDITIONAL_REQUIRED_TOGGLE_FIELDS = [
@@ -24,8 +49,21 @@ def test_conditional_required_fields_raises_exception(self):
 
         with self.assertRaises(ValueError):
             TestModel.objects.create(user=self.user)
+    
+    def test_conditional_required_toggle_field_raises_exception_when_multiple_provided(self):
+        from demo.models import TestModel
+
+        TestModel.CONDITIONAL_REQUIRED_TOGGLE_FIELDS = [
+            (
+                lambda instance: instance.user.is_active,
+                ["fixed_price", "percentage", "amount"],
+            ),
+        ]
+
+        with self.assertRaises(ValueError):
+            TestModel.objects.create(user=self.user, percentage=25, fixed_price=10)
 
-    def test_conditional_required_fields_is_valid(self):
+    def test_conditional_required_toggle_field_is_valid(self):
         from demo.models import TestModel
 
         TestModel.CONDITIONAL_REQUIRED_TOGGLE_FIELDS = [
@@ -53,6 +91,14 @@ def test_providing_a_required_field_saves_the_instance(self):
         obj = TestModel.objects.create(user=self.user, percentage=25)
 
         self.assertEqual(obj.percentage, 25)
+    
+    def test_providing_more_than_one_required_field_raises_an_error(self):
+        from demo.models import TestModel
+
+        TestModel.REQUIRED_FIELDS = ["percentage", "fixed_price"]
+
+        with self.assertRaises(ValueError):
+            TestModel.objects.create(user=self.user, percentage=25, fixed_price=10)
 
     def test_optional_required_fields_is_valid(self):
         from demo.models import TestModel

setup.py

@@ -79,7 +79,7 @@
         "django custom validation",
     ],
     classifiers=[
-        "Development Status :: 4 - Beta",
+        "Development Status :: 5 - Production/Stable",
         "Intended Audience :: Developers",
         "License :: OSI Approved :: MIT License",
         "License :: OSI Approved :: Apache Software License",