Merge pull-request #1096

Author: ethankonk

.changeset/lemon-breads-win.md

@@ -0,0 +1,5 @@
+---
+"@turnkey/core": patch
+---
+
+Fixed legacy transactions not working in `signAndSendTransaction()` for **EVM connected wallet**. This does not affect Turnkey's embedded wallet flow, previously, connected wallet transactions were all formatted into EIP-1559 transactions, updated to respect legacy + future formats passed in.

examples/with-sdk-js/src/app/layout.tsx

@@ -62,15 +62,15 @@ function RootLayout({ children }: RootLayoutProps) {
                   ],
                 },
               },
-              // walletConnect: {
-              //   projectId: process.env.NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID!,
-              //   appMetadata: {
-              //     name: "Turnkey Wallet",
-              //     description: "A wallet for Turnkey",
-              //     url: process.env.NEXT_PUBLIC_WALLETCONNECT_PROJECT_URL!,
-              //     icons: ["/favicon.svg"],
-              //   },
-              // },
+              walletConnect: {
+                projectId: process.env.NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID!,
+                appMetadata: {
+                  name: "Turnkey Wallet",
+                  description: "A wallet for Turnkey",
+                  url: process.env.NEXT_PUBLIC_WALLETCONNECT_PROJECT_URL!,
+                  icons: ["/favicon.svg"],
+                },
+              },
             },
           }}
         >

examples/with-sdk-js/src/app/page.tsx

@@ -1624,8 +1624,9 @@ export default function AuthPage() {
                 value: parseEther("0.001"),
                 nonce: 0,
                 gasLimit: BigInt("21000"),
-                maxFeePerGas: BigInt("1000000000"),
-                maxPriorityFeePerGas: BigInt("1000000000"),
+                gasPrice: BigInt("100000000000000"),
+                // maxFeePerGas: BigInt("1000000000"),
+                // maxPriorityFeePerGas: BigInt("1000000000"),
                 chainId: 1,
               };
 

packages/core/src/__types__/external-wallets.ts

@@ -218,3 +218,27 @@ export interface ConnectedWallet extends v1Wallet {
 
 /** @internal */
 export type Wallet = EmbeddedWallet | ConnectedWallet;
+
+export type EvmTransactionParams = {
+  from: `0x${string}`;
+  to: `0x${string}`;
+  value: `0x${string}`;
+  gas: `0x${string}`;
+  nonce: `0x${string}`;
+  chainId: `0x${string}`;
+  data: `0x${string}`;
+};
+
+export type EIP1559TransactionParams = EvmTransactionParams & {
+  maxFeePerGas: `0x${string}`;
+  maxPriorityFeePerGas: `0x${string}`;
+};
+
+export type LegacyEvmTransactionParams = EvmTransactionParams & {
+  gasPrice: `0x${string}`;
+};
+
+/** @internal */
+export type EthereumTxParams =
+  | EIP1559TransactionParams
+  | LegacyEvmTransactionParams;

packages/core/src/__wallet__/wallet-connect/base.ts

@@ -15,6 +15,8 @@ import {
   WalletConnectProvider,
   WalletConnectInterface,
   SwitchableChain,
+  EvmTransactionParams,
+  EthereumTxParams,
 } from "../../__types__";
 import type { WalletConnectClient } from "./client";
 import type { SessionTypes } from "@walletconnect/types";
@@ -320,20 +322,52 @@ export class WalletConnectWallet implements WalletConnectInterface {
             address,
           ])) as string;
         case SignIntent.SignAndSendTransaction:
-          const account = provider.connectedAddresses[0];
+          const account = provider.connectedAddresses[0] as Hex;
+          if (!account) throw new Error("no connected address");
           const tx = Transaction.from(payload);
-          const txParams = {
+
+          const base: EvmTransactionParams = {
             from: account,
             to: tx.to?.toString() as Hex,
             value: toHex(tx.value),
             gas: toHex(tx.gasLimit),
-            maxFeePerGas: toHex(tx.maxFeePerGas ?? 0n),
-            maxPriorityFeePerGas: toHex(tx.maxPriorityFeePerGas ?? 0n),
             nonce: toHex(tx.nonce),
             chainId: toHex(tx.chainId),
             data: (tx.data?.toString() as Hex) ?? "0x",
           };
 
+          // Some libs use undefined for legacy, so normalize
+          const txType = (tx as any).type ?? 0;
+
+          let txParams: EthereumTxParams;
+
+          if (txType === undefined || txType === 0 || txType === 1) {
+            // legacy or EIP-2930 (gasPrice-based)
+            if (tx.gasPrice == null) {
+              throw new Error(
+                "Legacy or EIP-2930 transaction missing gasPrice",
+              );
+            }
+
+            txParams = {
+              ...base,
+              gasPrice: toHex(tx.gasPrice),
+            };
+          } else {
+            // EIP-1559 or future fee-market types
+            if (tx.maxFeePerGas == null || tx.maxPriorityFeePerGas == null) {
+              throw new Error(
+                "EIP-1559-style transaction missing maxFeePerGas or maxPriorityFeePerGas",
+              );
+            }
+
+            txParams = {
+              ...base,
+              maxFeePerGas: toHex(tx.maxFeePerGas),
+              maxPriorityFeePerGas: toHex(tx.maxPriorityFeePerGas),
+            };
+          }
+
           return (await this.client.request(
             this.ethChain,
             "eth_sendTransaction",

packages/core/src/__wallet__/web/native/ethereum.ts

@@ -9,7 +9,9 @@ import {
 import { Transaction } from "ethers";
 import { compressRawPublicKey } from "@turnkey/crypto";
 import {
+  EvmTransactionParams,
   Chain,
+  EthereumTxParams,
   EthereumWalletInterface,
   SignIntent,
   SwitchableChain,
@@ -279,24 +281,54 @@ export class EthereumWallet extends BaseEthereumWallet {
           params: [payload as Hex, account],
         });
 
-      case SignIntent.SignAndSendTransaction:
+      case SignIntent.SignAndSendTransaction: {
         const tx = Transaction.from(payload);
-        const txParams = {
+
+        const base: EvmTransactionParams = {
           from: account,
           to: tx.to?.toString() as Hex,
           value: toHex(tx.value),
           gas: toHex(tx.gasLimit),
-          maxFeePerGas: toHex(tx.maxFeePerGas ?? 0n),
-          maxPriorityFeePerGas: toHex(tx.maxPriorityFeePerGas ?? 0n),
           nonce: toHex(tx.nonce),
           chainId: toHex(tx.chainId),
           data: (tx.data?.toString() as Hex) ?? "0x",
         };
 
+        // Some libs use undefined for legacy, so normalize
+        const txType = (tx as any).type ?? 0;
+
+        let txParams: EthereumTxParams;
+
+        if (txType === undefined || txType === 0 || txType === 1) {
+          // legacy or EIP-2930 (gasPrice-based)
+          if (tx.gasPrice == null) {
+            throw new Error("Legacy or EIP-2930 transaction missing gasPrice");
+          }
+
+          txParams = {
+            ...base,
+            gasPrice: toHex(tx.gasPrice),
+          };
+        } else {
+          // EIP-1559 or future fee-market types
+          if (tx.maxFeePerGas == null || tx.maxPriorityFeePerGas == null) {
+            throw new Error(
+              "EIP-1559-style transaction missing maxFeePerGas or maxPriorityFeePerGas",
+            );
+          }
+
+          txParams = {
+            ...base,
+            maxFeePerGas: toHex(tx.maxFeePerGas),
+            maxPriorityFeePerGas: toHex(tx.maxPriorityFeePerGas),
+          };
+        }
+
         return await selectedProvider.request({
           method: "eth_sendTransaction",
           params: [txParams],
         });
+      }
 
       default:
         throw new Error(`Unsupported sign intent: ${intent}`);