SciPy depreciated tol in favour of rtol

[davidzentlermunro]

Hi,

Thanks for the great resource! A very small issue: SciPy (1.14) has depreciated 'tol' in favour of 'rtol'. This leads to the following error being thrown:

TypeError: minres() got an unexpected keyword argument 'tol'

Of course this can be solved by downgrading to SciPay 1.13, but you may wish to update tol to rtol so pytwoway is compatible with latest versions.

Thanks again!

D

[adamoppenheimer]

Hi David,

Thank you for the information!

I labeled this as a bug, but in the meantime I unfortunately don't have time to update the code for PyTwoWay.

However, this should be useful for people to see in the future so they know which version of SciPy to use.

An additional way to handle this is to specify the 'solver' option in fe_params to something other than 'minres'. You can see the options by running tw.fe_params().describe('solver').

Best,
Adam