Skip to content

Get by key value is broken, must use Get by object #315

@kspdrgn

Description

@kspdrgn

Sorry if this is a duplicate. Maybe this will help other developers running into this issue.

Using Get as the documentation suggests Get(id) doesn't work, it doesn't generate any predicate. Must use Get(new { id }) syntax.

This bug may affect all providers, I have only tested SQL Server.

The predicate is not filled out when using Get(value) but they work when using Get(object). I noticed that in DapperImplementor.GetMapAndPredicate, GetKeyPredicate is only called for Update and Delete, not Get.

Workaround for developers is to use Get(new {}) syntax.

Workaround for Dapper-Extensions may be to fix the documentation to say Get(new { id }) instead of Get(id).

See pull request with a corrected test case that shows Get is failing

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions