Skip to content

feat(files-widget): notify after sending inline comments#31

Merged
tmustier merged 2 commits into
mainfrom
feat/files-widget-p1-comment-notify
Apr 19, 2026
Merged

feat(files-widget): notify after sending inline comments#31
tmustier merged 2 commits into
mainfrom
feat/files-widget-p1-comment-notify

Conversation

@tmustier
Copy link
Copy Markdown
Owner

Summary

  • show a success toast after an inline comment is sent back to the agent
  • include the file path and line range in the notification for quick confirmation
  • mark the remaining comment-send notification TODO item as done

Validation

  • tsc --noCheck --noEmit --moduleResolution nodenext --module nodenext --target ES2022 files-widget/*.ts

@tmustier
Copy link
Copy Markdown
Owner Author

pr-reviewer run 1

Findings

  • [P2] Success toast reports queued comments as already sent
    files-widget/index.ts:48
    pi.sendUserMessage(..., { deliverAs: "followUp" }) does not deliver immediately while the agent is streaming; per the API docs it queues the message until the current run finishes. The new “Comment sent to agent…” toast therefore gives false confirmation in the busy case, which is exactly when inline comments are likely to be used.
    Check ctx.isIdle?.() before choosing the toast text, or show “queued” while streaming instead of “sent”.

Verdict

needs attention — the new notification can claim delivery before the agent has actually received the inline comment.

@tmustier
Copy link
Copy Markdown
Owner Author

pr-reviewer run 2

Findings

Code looks good.

Verdict

correct — no remaining P0-P2 issues found in the current PR diff against main.

@tmustier tmustier merged commit 123f85d into main Apr 19, 2026
1 check passed
@tmustier tmustier deleted the feat/files-widget-p1-comment-notify branch April 19, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant