please add support for : within json value

[kevintechie]

Can't add URLs via superagent-cli because the : character breaks the command line parser.

For example: {"websiteUrl": "http://foo.com"} generates an unexpected token error and points to the : character.

[toastynerd]

Interesting, does it work if you wrap the whole thing in single quotes ex: '{"websiteUrl": "http://foo.com"}'?

[kevintechie]

If I wrap the JSON in single quotes, I get nothing in the request body in my app. The strange thing is is that if I do the same thing using get, it works. Post seems to have the problem. I can demo for you if you want.

[toastynerd]

I'm not getting the same issue with the notes server, can you point me in the direction of your server repo? I want to see if this is a windows only issue or if it affects everything, I'll patch it either way I just want to confirm before I try to make a solution. Also, if you could get me the details of the setup you're using that would be helpful as well (you can pm me if you don't want to post it here).

[kevintechie]

Config Info: Windows 7 Ultimate, cmd shell, superagent-cli 1.4.4

Also, I think the get works because it's a single JSON element with a value w/o a space. (used when passing in the eat token.)

[kevintechie]

Here's a repo you can use to demo. https://github.com/CF-PatronOfTheArts/PatronServer

[toastynerd]

Alright, looks like this is something to do with Windows. I'll set up my gaming rig at home for some dev stuff and see if I can figure it out.

[kevintechie]

I was curious about this bug, so I did some digging. There are several things that conspire together to produce this bug. The main problem on Windows is that you have to wrap arguments in double quotes if you want to pass arguments that contains spaces. This means that you can't pass valid JSON as an argument on the command line on Windows.

I'm not sure how to resolve the issue exactly if you want to pass valid JSON. An option is to use a substitute character (e.g. single quote) for double quotes and then replace the substitute character in the parsing process. However, you'll have to escape the substitute character because anything inside a pair of double quotes is valid JSON data. In addition, you'll have to explain the technique in the help. Overall, it's an inelegant, if simple, solution.

You could make the solution platform specific so non-Windows users would not have to worry about it.

Another option (and possible feature) is to pass in the name of a file that contains the request body.

[toastynerd]

Huh, that's interesting. Also I like the idea of being able to pass in a file.

[kevintechie]

Well, I implemented the external file feature and added a test. I'm sure you saw the pull request.