Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package "go get" compatible #5

Open
ChimeraCoder opened this issue Jul 22, 2014 · 2 comments
Open

Make package "go get" compatible #5

ChimeraCoder opened this issue Jul 22, 2014 · 2 comments

Comments

@ChimeraCoder
Copy link

There are two things which prevent this package from being go get compatible and idiomatic. The first can be fixed with a pull request, but the second requires changing the repository name/location.

Go projects use a single directory for all files in a package, and this directory generally has the same name as the package name (so src directories aren't used in Go projects).

However, project names that end in .go are no longer recognized by the entire Go toolchain, which means that the project name should really be underscore (or perhaps __, not `underscore.go).

(I was going to submit a pull request, but then I realized that the respository name ended in .go, which ideally should be fixed before moving the files out of the src directory; doing this in the other order would result in an inconsistent intermediate state.)

@tobyhede
Copy link
Owner

Thanks for the feedback. I think have this one sorted now - repo name has changed, src is being moved out of the sub directory.

I am also not using the __ anymore because the general feedback was it was too close to _.

@tobyhede
Copy link
Owner

Thanks for your help too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants