Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1844] Unable to purchase private below half price #11551

Open
uncalled1st opened this issue Feb 15, 2025 · 1 comment · May be fixed by #11615
Open

[1844] Unable to purchase private below half price #11551

uncalled1st opened this issue Feb 15, 2025 · 1 comment · May be fixed by #11615
Labels
1844 bug Prevents game from being played correctly

Comments

@uncalled1st
Copy link

Game ID 194981

https://18xx.games/game/31337

How to Reproduce the Bug?
Go back to
1844: Phase 4 - Operating Round 6.1 (of 2) - Buy Trains
[07:15] RhB buys a 3H train for 80 SFR from AB

Try to buy P4 for 1 SFR
Note shows 55-220 required for purchase price, but rules allow 1 to 220

Image

Chrome Win 11
Version 132.0.6834.160 (Official Build) (64-bit)

@philcampeau philcampeau added bug Prevents game from being played correctly 1844 and removed needs triage labels Feb 17, 2025
@philcampeau
Copy link
Collaborator

philcampeau commented Feb 17, 2025

Yes, this is definitely a bug. The current implementation just uses the default half-to-double price for private company buy-ins.

It seems like this should be as simple as creating a company_price_one_to_double.rb file in /lib/engine/game/ and then calling it in 1844, but when I do this I get rake errors on existing games.

Interested to see the correct solution to know what I'm doing wrong.

@philcampeau philcampeau linked a pull request Mar 12, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1844 bug Prevents game from being played correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants