[1844] sets min buy-in price to 1 SFR #11615
Open
+17,517
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
added
migrate_game
|
The default game migration script should be able to fix any games broken by this. It will add additional pass actions where needed. |
ollybh
approved these changes
Mar 12, 2025
|
Very true! I just ran the migrate script on the existing fixture file and it worked fine, so I've restored it with the migrate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11551
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Currently, buy-in price was using the default half to double. Rules state it's 1 to double.
I created a new company_price_one_to_double.rb file in /lib/engine/game (similar to the other current files there) and made the necessary changes to 1844's game.rb code.
I needed to delete the fixture file, and likely many (probably all) existing games will need to be pinned, since any game that skipped over the buy companies blocking step will now re-evaluate that decision if a corp has at least 1 SFR in its treasury.
Screenshots
Any Assumptions / Hacks