Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Steam Over Holland] fixes EMR bug #11607

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

philcampeau
Copy link
Collaborator

@philcampeau philcampeau commented Mar 7, 2025

Fixes #11184
Fixes #11581

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

In def actions(entity), I had these two lines in the reverse order:

return ['sell_shares'] if entity == current_entity&.owner && can_ebuy_sell_shares?(current_entity)
return [] if entity != current_entity

which caused the error.

I also added a couple of small improvements to the code, fixing how the share sales were treated depending on if it was a sale or issuing.

@philcampeau philcampeau added the archive_alpha_games Needs alpha games archiving label Mar 9, 2025
@philcampeau
Copy link
Collaborator Author

It looks like the old fixture file I had didn't work anymore, so we might have to archive the alpha games. I added the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants