-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending SIGTERM to tenv put terraform state at risk #340
Comments
although, I think the simplest fix is to remove the signal transmission on non Windows system... I will try to do a PR and propose a beta for that soon |
Hello,
Found 2 other issues that are the same I believe see below. I had to enable TENV_DETACHED_PROXY because the binary would not run on MAC with the ioctl error seems related to this issue #328. This issue show up when running tenv within pre-commit
Here are the two issues that were closed and are the same "Ctrl-C" double. Thanks for working on tenv @dvaumoron it is greatly appreciated! |
Also see #305 |
Can you test v4.2.0-beta2 ? |
Hello @dvaumoron worked seems to work for me for this issue. |
Describe the bug
When using tenv with terraform.
If a user issue one SIGTERM to tenv, tenv send two SIGTERM to terraform without giving time to Terraform to cleanly stop.
Ending up with locked state, and risk of corrupting Terraform state file.
To Reproduce
Set
export TENV_DETACHED_PROXY=false
because otherwise tenv does not work.using terraform example
Expected behavior
tenv should only send the same amount of SIGTERM received and not two.
Screenshots
See description above
Environment (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: