refactor: Address code review comments

Author: sbassam

src/together/filemanager.py

@@ -6,10 +6,10 @@
 import stat
 import tempfile
 import uuid
-from concurrent.futures import ThreadPoolExecutor, as_completed
+from concurrent.futures import Future, ThreadPoolExecutor, as_completed
 from functools import partial
 from pathlib import Path
-from typing import Any, Dict, List, Tuple
+from typing import Any, BinaryIO, Dict, List, Tuple
 
 import requests
 from filelock import FileLock
@@ -513,6 +513,18 @@ def _initiate_upload(
 
         return response.data
 
+    def _submit_part(
+        self,
+        executor: ThreadPoolExecutor,
+        f: BinaryIO,
+        part_info: Dict[str, Any],
+        part_size: int,
+    ) -> Future[str]:
+        """Submit a single part for upload and return the future"""
+        f.seek((part_info["PartNumber"] - 1) * part_size)
+        part_data = f.read(part_size)
+        return executor.submit(self._upload_single_part, part_info, part_data)
+
     def _upload_parts_concurrent(
         self, file: Path, upload_info: Dict[str, Any], part_size: int
     ) -> List[Dict[str, Any]]:
@@ -530,12 +542,7 @@ def _upload_parts_concurrent(
                     # Submit initial batch limited by max_concurrent_parts
                     for i in range(min(self.max_concurrent_parts, len(parts))):
                         part_info = parts[part_index]
-                        f.seek((part_info["PartNumber"] - 1) * part_size)
-                        part_data = f.read(part_size)
-
-                        future = executor.submit(
-                            self._upload_single_part, part_info, part_data
-                        )
+                        future = self._submit_part(executor, f, part_info, part_size)
                         future_to_part[future] = part_info["PartNumber"]
                         part_index += 1
 
@@ -556,11 +563,8 @@ def _upload_parts_concurrent(
                         # Submit next part if available
                         if part_index < len(parts):
                             part_info = parts[part_index]
-                            f.seek((part_info["PartNumber"] - 1) * part_size)
-                            part_data = f.read(part_size)
-
-                            future = executor.submit(
-                                self._upload_single_part, part_info, part_data
+                            future = self._submit_part(
+                                executor, f, part_info, part_size
                             )
                             future_to_part[future] = part_info["PartNumber"]
                             part_index += 1

src/together/utils/files.py

@@ -366,9 +366,9 @@ def _check_utf8(file: Path) -> Dict[str, Any]:
     report_dict: Dict[str, Any] = {}
 
     try:
-        chunk_size = 8192
+        # Dry-run UTF-8 decode: iterate through file to validate encoding
         with file.open(encoding="utf-8") as f:
-            for chunk in iter(lambda: f.read(chunk_size), ""):
+            for _ in f:
                 pass
 
         report_dict["utf8"] = True