Skip to content

Conversation

@Danil42Russia
Copy link

@Danil42Russia Danil42Russia commented Nov 23, 2025

Closed #1416

Unfortunately, there will still be gaps in some parts of the documentation due to the .remarkignore being ignored. If you don't mind, I would also remove the spaces at the end there.

@github-actions
Copy link

Skipping AI review because this PR is from a fork. A maintainer can start the review by commenting /review in this PR.

@anton-trunov
Copy link
Collaborator

@Danil42Russia thanks for you contribution

it's definitely not a feature (feat), please fix the PR title and open the corresponding issue as per the workflow: #1366

@Danil42Russia Danil42Russia changed the title feat: removed spaces at the end chore: removed spaces at the end Nov 23, 2025
@Danil42Russia
Copy link
Author

@anton-trunov, fixed

@novusnota novusnota self-requested a review November 24, 2025 12:43
Copy link
Collaborator

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The end-of-line spaces are handled by EditorConfig-compatible editors and plugins, but it's good to explicitly make the formatter do so too.

Regarding ignored files — don't :) The whitepapers there are frequently changed as of now, and their formatting is probably the last thing we'll do after that process ends.

@novusnota novusnota changed the title chore: removed spaces at the end chore(format): remove end-of-line spaces via remark-lint-no-trailing-spaces Nov 24, 2025
Copy link
Collaborator

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've formatted touched files once again. Weirdly enough, remark-lint-no-trailing-spaces does not remove the trailing spaces, only warns about them. You might consider removing it from package.json and reverting the package-lock.json changes.

In any case, we'll probably switch to a .mjs config for remark soon, to fine tune it and allow reuse in scripts/. There, I'll make it trim unnecessary spaces :)

@novusnota novusnota changed the title chore(format): remove end-of-line spaces via remark-lint-no-trailing-spaces chore(format): remove end-of-line spaces spotted by remark-lint-no-trailing-spaces Nov 24, 2025
@Danil42Russia
Copy link
Author

Yes, unfortunately, remark-lint-no-trailing-spaces cannot fix errors :(
But I suggest leaving it so that no new errors appear. Then it can be removed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Format] Do not use spaces at the end

3 participants