-
Notifications
You must be signed in to change notification settings - Fork 15
chore(format): remove end-of-line spaces spotted by remark-lint-no-trailing-spaces
#1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(format): remove end-of-line spaces spotted by remark-lint-no-trailing-spaces
#1415
Conversation
|
Skipping AI review because this PR is from a fork. A maintainer can start the review by commenting /review in this PR. |
|
@Danil42Russia thanks for you contribution it's definitely not a feature ( |
|
@anton-trunov, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The end-of-line spaces are handled by EditorConfig-compatible editors and plugins, but it's good to explicitly make the formatter do so too.
Regarding ignored files — don't :) The whitepapers there are frequently changed as of now, and their formatting is probably the last thing we'll do after that process ends.
remark-lint-no-trailing-spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've formatted touched files once again. Weirdly enough, remark-lint-no-trailing-spaces does not remove the trailing spaces, only warns about them. You might consider removing it from package.json and reverting the package-lock.json changes.
In any case, we'll probably switch to a .mjs config for remark soon, to fine tune it and allow reuse in scripts/. There, I'll make it trim unnecessary spaces :)
remark-lint-no-trailing-spacesremark-lint-no-trailing-spaces
|
Yes, unfortunately, |
Closed #1416
Unfortunately, there will still be gaps in some parts of the documentation due to the
.remarkignorebeing ignored. If you don't mind, I would also remove the spaces at the end there.