Don't substitute primary key when impersonating the control page

This causes the wrong inline child objects to be picked up. Fixes #11

Author: gasman

CHANGELOG.txt

@@ -6,6 +6,7 @@ Changelog
 
  * Remove detection of bots by user-agent, as this directly contravenes Google's guidelines
    (https://webmasters.googleblog.com/2012/08/website-testing-google-search.html)
+ * Fix: Page ID is no longer switched when rendering alternative pages, so that the correct inline child objects are displayed
 
 
 0.1.1 (01.11.2016)

experiments/utils.py

@@ -16,8 +16,6 @@ def percentage(fraction, population):
 
 def impersonate_other_page(page, other):
     """Modify the title and tree location data of `page` to resemble `other`"""
-    page.id = other.id
-    page.pk = other.pk
     page.path = other.path
     page.depth = other.depth
     page.url_path = other.url_path

tests/templates/tests/simple_page.html

@@ -7,7 +7,7 @@
         <h1>{{ page.title }}</h1>
         <ul class="breadcrumb">
             {% for p in breadcrumb %}
-                <li {% if p.pk == page.pk %}class="current"{% endif %}>{{ p.title }}</li>
+                <li {% if p.url_path == page.url_path %}class="current"{% endif %}>{{ p.title }}</li>
             {% endfor %}
         </ul>
         <p>{{ page.body }}</p>

tests/tests.py

@@ -41,6 +41,7 @@ def test_selected_variation_depends_on_user_id(self):
             response = self.client.get('/')
             self.assertEqual(response.status_code, 200)
             self.assertContains(response, '<p>Welcome to our site!</p>')
+            self.assertContains(response, '<a href="http://boring.example.com/">a boring link</a>')
 
         session.clear()
         session['experiment_user_id'] = '33333333-3333-3333-3333-333333333333'
@@ -50,6 +51,7 @@ def test_selected_variation_depends_on_user_id(self):
             response = self.client.get('/')
             self.assertEqual(response.status_code, 200)
             self.assertContains(response, '<p>Welcome to our site! It&#39;s lovely to meet you.</p>')
+            self.assertContains(response, '<a href="http://lovely.example.com/">a lovely link</a>')
 
     def test_participant_is_logged(self):
         # initially there should be no experiment history
@@ -197,6 +199,7 @@ def test_draft_status(self):
         # but should get the standard homepage when it's draft
         self.assertEqual(response.status_code, 200)
         self.assertContains(response, '<p>Welcome to our site!</p>')
+        self.assertContains(response, '<a href="http://boring.example.com/">a boring link</a>')
 
         # no participant record should be logged
         self.assertEqual(ExperimentHistory.objects.filter(experiment=self.experiment).count(), 0)