Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul core Tracker: extract workspace package for the tracker core lib #1223

Closed
josecelano opened this issue Jan 29, 2025 · 0 comments · Fixed by #1225
Closed

Overhaul core Tracker: extract workspace package for the tracker core lib #1223

josecelano opened this issue Jan 29, 2025 · 0 comments · Fixed by #1225
Assignees
@josecelano
Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat

Comments

@josecelano
Copy link
Member

josecelano commented Jan 29, 2025 •
edited
Loading

Parent issue: #1181

Create a new workspace package for the core tracker module: src/core.

  • Package folder: ./packages/tracker-core-lib
  • Crate name: bittorrent-tracker-core-lib

This would allow other projects to use the same core tracker logic and I would make harder to pollute the core tracker with higher level login like web frameworks, etc.

Database migration are only used inside the core tracker module, so they have to be moved into the new package.

cc @da2ce7
@josecelano josecelano added - Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat labels Jan 29, 2025
@josecelano josecelano self-assigned this Jan 29, 2025
@josecelano josecelano mentioned this issue Jan 29, 2025
Open
24 tasks
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 29, 2025
@josecelano
refactor: [torrust#1223] extract tracker-core workspace package
d29a709
@josecelano josecelano linked a pull request Jan 29, 2025 that will close this issue
Overhaul core Tracker: extract workspace package tracker-core #1225
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 29, 2025
@josecelano
refactor: [torrust#1223] extract tracker-core workspace package
a6f26f8
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 29, 2025
@josecelano
refactor: [torrust#1223] extract tracker-core workspace package
d93c070
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 29, 2025
@josecelano
refactor: [torrust#1223] extract tracker-core workspace package
188c8b9
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 29, 2025
@josecelano
refactor: [torrust#1223] extract tracker-core workspace package
3549264
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 29, 2025
@josecelano
refactor: [torrust#1223] extract tracker-core workspace package
a5ca244
josecelano added a commit that referenced this issue Jan 29, 2025
@josecelano
Merge #1225: Overhaul core Tracker: extract workspace package `tracke…
4447c6a 
…r-core`

a5ca244 refactor: [#1223] extract tracker-core workspace package (Jose Celano)

Pull request description:

  Overhaul core Tracker: extract workspace package `tracker-core`.

ACKs for top commit:
  josecelano:
    ACK a5ca244

Tree-SHA512: c0471f3adb8eddcb4b5615409e64dcb8c8cf49969a2a4698570ee34c24731a50980b95fa76546b0a010e22e7428b42de3d31711d74b4d70501105cf06153c117
@josecelano josecelano mentioned this issue Jan 29, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul core Tracker: extract workspace package tracker-core josecelano/torrust-tracker
1 participant
@josecelano