Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul core Tracker: review public methods for tracker-core package #1258

Closed
josecelano opened this issue Feb 11, 2025 · 0 comments · Fixed by #1259
Closed

Overhaul core Tracker: review public methods for tracker-core package #1258

josecelano opened this issue Feb 11, 2025 · 0 comments · Fixed by #1259
Assignees
@josecelano
Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat

Comments

@josecelano
Copy link
Member

Parent issue: #1181

I want to make private functions we don't use outside the package.
@josecelano josecelano added - Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat labels Feb 11, 2025
@josecelano josecelano self-assigned this Feb 11, 2025
@josecelano josecelano mentioned this issue Feb 11, 2025
Open
22 tasks
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 11, 2025
@josecelano
refactor: [torrust#1258] make mdoules with testing funtions pub only …
abc3d97 
…for crate
@josecelano josecelano linked a pull request Feb 11, 2025 that will close this issue
Overhaul core Tracker: review public methods for tracker-core package #1259
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 11, 2025
@josecelano
refactor: [torrust#1258] make modules with testing funtions pub only …
b279628 
…for crate
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 11, 2025
@josecelano
refactor: [torrust#1258] make things private or pub(crate) when possi…
bbb2cd8 
…ble.

Limit the exposed funtionality for pacakges. Specially the new
`tracker-core` package which has not been published yet.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 11, 2025
@josecelano
refactor: [torrust#1258] make things private or pub(crate) when possi…
139453d 
…ble.

Limit the exposed funtionality for pacakges. Specially the new
`tracker-core` package which has not been published yet.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 11, 2025
@josecelano
refactor: [torrust#1258] make things private or pub(crate) when possi…
62e9eba 
…ble.

Limit the exposed funtionality for pacakges. Specially the new
`tracker-core` package which has not been published yet.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 11, 2025
@josecelano
refactor: [torrust#1258] make things private or pub(crate) when possi…
53b94a3 
…ble.

Limit the exposed funtionality for pacakges. Specially the new
`tracker-core` package which has not been published yet.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 11, 2025
@josecelano
refactor: [torrust#1258] make things private or pub(crate) when possi…
9337817 
…ble.

Limit the exposed funtionality for pacakges. Specially the new
`tracker-core` package which has not been published yet.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 12, 2025
@josecelano
refactor: [torrust#1258] make things private or pub(crate) when possi…
6639c98 
…ble.

Limit the exposed funtionality for pacakges. Specially the new
`tracker-core` package which has not been published yet.
josecelano added a commit that referenced this issue Feb 12, 2025
@josecelano
Merge #1259: Overhaul core Tracker: review public methods for `tracke…
efe7e98 
…r-core` package

6639c98 refactor: [#1258] make things private or pub(crate) when possible. (Jose Celano)

Pull request description:

  Overhaul core Tracker: review public methods for `tracker-core` package.

ACKs for top commit:
  josecelano:
    ACK 6639c98

Tree-SHA512: 0f45460320a3bd587e0e51eb92f2bfb73d5c889f1279d48668680b886c612d9af96fe1710a1526c6fd67ec540d85110f5031eaf5fe078980c043024caa943d47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul core Tracker: review public methods for tracker-core package josecelano/torrust-tracker
1 participant
@josecelano