Skip to content

Conversation

@wo-o29
Copy link
Contributor

@wo-o29 wo-o29 commented Nov 26, 2025

📝 Key Changes

Fixed modal accessibility documentation issue where the example screen reader output showed incorrect text that doesn't exist in the code example.

Problem Clarification:

  • In the code example, aria-labelledby="modal-title" references an <h3 id="modal-title"> element containing the text "다음에 다시 시도해 주세요"
  • The text "제목은 한 줄로 써주세요" mentioned in the screen reader example does not exist anywhere in the provided code
  • This created confusion about the expected screen reader output

Changes made:

  • Corrected the screen reader output example to reflect the actual text content in the code
  • Clarified that the expected output should be "다음에 다시 시도해 주세요, 대화상자" based on the real modal title text
  • Removed references to non-existent placeholder text in the accessibility example

🖼️ Before and After Comparison

Before After
스크린샷 2025-11-26 오후 1 00 28 스크린샷 2025-11-26 오후 1 01 37

@vercel
Copy link

vercel bot commented Nov 26, 2025

@wo-o29 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@kss2002
Copy link

kss2002 commented Nov 26, 2025

  • wo-o29님이 찾아내신 모달 관련 링크 첨부

https://frontend-fundamentals.com/a11y/ui-foundation/modal.html

@wo-o29
Copy link
Contributor Author

wo-o29 commented Nov 27, 2025

  • wo-o29님이 찾아내신 모달 관련 링크 첨부

https://frontend-fundamentals.com/a11y/ui-foundation/modal.html

감사합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants